Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Include Vue methods in ArgsTable #18609

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 30, 2022

Replaces See #13127
Because the contributor deleted their repository, I cannot get it updated with changes from next

Issue: Methods not shown use ArgsTable with vue framework( #13105)

add SECTION Methods

test in node_modules: change file content as same as in PR(node_modules@storybook\addon-docs\dist\frameworks\vue\extractArgTypes.js),and it worked in my project

@hmleo

@nx-cloud
Copy link

nx-cloud bot commented Jun 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 42da265. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen
Copy link
Member Author

@storybookjs/vue Could anyone help me out verify this? And perhaps add a testcase / story demonstrating the feature?

@pocka
Copy link
Contributor

pocka commented Jul 1, 2022

@ndelangen Is this PR #16975 but for Vue3? It seems that PR fixed the original issue (for Vue2).

@ndelangen
Copy link
Member Author

I honestly do not know @pocka that sounds about right. I was trying to bring a list of PRs to a close because having 120+ PRs doesn't reflect well on the project and is just rude to the people giving up their time making these PRs.

Any help you could offer to understand the issues this pr is solving would be appreciated

@ndelangen
Copy link
Member Author

Yes, @pocka you're 100% correct! Thank you for pointing that out.

@ndelangen ndelangen merged commit 834f8cf into next Jul 1, 2022
@ndelangen ndelangen deleted the hmleo/vue-methods branch July 1, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants