Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs/Vue: Include methods in ArgsTable #16975

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

linker-junhao
Copy link
Contributor

Issue: Methods not shown use ArgsTable with vue framework( #13105)

What I did

the change I made is the same as the pull request(13127)
more I did is add jsdoc comment for requestButton method in examples/vue-kitchen-sin/src/stories/Welcome.vue , I think it's enough to be an example.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 072a9d4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Addon-docs: Include Vue methods in ArgsTable Addon-docs/Vue: Include methods in ArgsTable Jan 3, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @linkerGitHub, this looks great & appreciate the example! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants