Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme to populate the markdown styles #602

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

trajano
Copy link
Contributor

@trajano trajano commented Sep 21, 2024

Issue: only the text was converted to the theme color, this ensures all other elements are switched to the theme color

What I did

useMemo against the theme default color to create a markdown stylesheet and applied that to the markdown element

How to test

Please explain how to test your changes and consider the following questions

  • Does this need a new example in examples/expo-example?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@trajano trajano changed the base branch from next to feat/v8 September 21, 2024 20:04
@trajano trajano mentioned this pull request Sep 21, 2024
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some small adjustments but looks like we're good, thanks for the contribution 🙏

@dannyhw dannyhw merged commit cfdf9be into storybookjs:feat/v8 Sep 22, 2024
1 check passed
@trajano trajano deleted the patch-2 branch September 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants