darkmode support #601
Closed
darkmode support #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey this seems great, do you think you could apply the changes to the v8 branch instead? Planning to release in the next few weeks |
|
@dannyhw I checked the v8 branch, you're doing it already though only for the main text. |
|
I hope that the upgrade from V7 to V8 won't be too painful :D @dannyhw |
|
There will be a guide but its not so different, just some new packages to install |
|
I'm not planning on releasing any more versions for v7 outside of hotfixes so hopefully you don't mind if I close this since the changes were already applied in the beta version |
|
thanks again for your contribution, its looking good in the new beta :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: add dark mode support to Notes
What I did
Set the dark mode style if it is dark mode
How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.