feat: add redirect field to voucher nbs
#310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd like to allow clients (especially on the web) to specify a redirect when registering a new space. To do this we add a `redirect` field to `voucher/claim` and `voucher/redeem` and use it to decide whether to send a user to the normal landing page or to redirect them to the specified URL after claiming and redeeming a voucher.
travis
requested review from
jchris,
Gozala,
alanshaw,
gobengo and
hugomrdias
|
fixes #291 |
|
general approach seems workable so far, and working through ci test failures will unblock merging |
|
closing in favor of the work in #399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to allow clients (especially on the web) to specify a redirect when registering a new space. To do this we add a
redirectfield tovoucher/claimandvoucher/redeemand use it to decide whether to send a user to the normal landing page or to redirect them to the specified URL after claiming and redeeming a voucher.This is my first time in this code, so looking for careful review and suggestions for improvement - happy to write tests, more docs, etc but wanted to validate the approach before I get too deep.