Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add redirect URL to validation request UCAN #291

Open
jchris opened this issue Dec 13, 2022 · 2 comments
Open

add redirect URL to validation request UCAN #291

jchris opened this issue Dec 13, 2022 · 2 comments
Assignees
@travis
Milestone
w3up phase 2

Comments

@jchris
Copy link
Contributor

jchris commented Dec 13, 2022

This will be in a fact field.

We also need to add type validation in the fact fields we use.

This enables apps to redirect back to themselves.

  • Voucher claim needs to have the redirect URL in the fact, and the voucher redeem in the email also need to have it.
@jchris jchris mentioned this issue Dec 13, 2022
Open
@Gozala
Copy link
Contributor

Gozala commented Dec 13, 2022

Any reason why it should be in fct as opposed to inside an nb instead ? I would like to make case for later because given the way ucan-wg/invocation#1 is shaping up it's not clear if we'll have a same fct for a whole batch of invocations or a single one making things trickier.

It's also fct is an array so it would require additional signaling which would complicate matter even more

@travis travis mentioned this issue Dec 14, 2022
Closed
@jchris jchris mentioned this issue Dec 15, 2022
Closed
@jchris
Copy link
Contributor Author

jchris commented Dec 15, 2022

As mentioned in #318, we should also put the space nickname in the protocol so it can be in the email

@hugomrdias hugomrdias added this to the w3up phase 2 milestone Jan 12, 2023
@hugomrdias hugomrdias mentioned this issue Jan 12, 2023
Closed
95 tasks
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@olizilla
feat: publish console to IPFS & Cloudflare from CI (storacha#287)
e2a833e 
Adds CI workflow to publish console to IPFS via web3.storage and
Cloudflare Pages.

- fixes storacha#291 
- PRs get a comment with the cloudflare dev url and an ipfs gateway url
on.
- merging PR to main updated dnslink for console.web3.storage and
creates a prod deploy for the w3console project in cloudflare pages
which should be configured to update the deployed site at
console.web3.storage

This is an iteration on the way we deploy the website in the
web3.storage repo, see:
https://github.com/web3-storage/web3.storage/blob/c973e7e0b29bc2f1bc6da348cdd2f66b0e00b1a3/.github/workflows/website.yml#L197-L243

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@olizilla
feat: publish console to IPFS & Cloudflare from CI (storacha#287)
df4715a 
Adds CI workflow to publish console to IPFS via web3.storage and
Cloudflare Pages.

- fixes storacha#291 
- PRs get a comment with the cloudflare dev url and an ipfs gateway url
on.
- merging PR to main updated dnslink for console.web3.storage and
creates a prod deploy for the w3console project in cloudflare pages
which should be configured to update the deployed site at
console.web3.storage

This is an iteration on the way we deploy the website in the
web3.storage repo, see:
https://github.com/web3-storage/web3.storage/blob/c973e7e0b29bc2f1bc6da348cdd2f66b0e00b1a3/.github/workflows/website.yml#L197-L243

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis travis

Labels
None yet
Projects
None yet
Milestone
w3up phase 2
Development

No branches or pull requests
4 participants
@jchris @travis @Gozala @hugomrdias