fix: did:mailto format per DID-core spec #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
lgtm. I found myself wondering "what if email local-part is not something simple like 'alice', but instead has more unusual chars in it?". I assume we should expect percent-encoded entities in the 4th ':'-delimited segment of did:mailto:domain:local-part?
i.e.
const didMailto = `did:mailto:web.mail:alice-with-weird-chars`
const parts = didMailto.split(':')
const email = `${decodeUriComponent(parts[2])@${parts[1]}`
alanshaw
approved these changes
Oct 24, 2023
Merged
Gozala
added a commit
that referenced
this pull request
Jan 22, 2024
Document UCAN spec extensions we use and assume. Based on #31 --------- Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28
I chose to not do percent encoding because:
@in URIs/delimiter