feat: ucan ext #102
Merged
feat: ucan ext #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alanshaw
requested changes
Jan 22, 2024
Comment on lines
+199
to
+203
| ### Revocation Revocation | ||
|
|
||
| It is RECOMMENDED to treat revocations permanent. Even though enclosing [UCAN] could be revoked it MUST NOT be interpreted as revocation of the revocation. | ||
|
|
||
| Enclosing [UCAN] revocation offers a mechanism to revoke authorization that [authority] MAY have given to another principal to revoke [UCAN]s on their behalf. |
There was a problem hiding this comment.
Suggested change
| ### Revocation Revocation | |
| It is RECOMMENDED to treat revocations permanent. Even though enclosing [UCAN] could be revoked it MUST NOT be interpreted as revocation of the revocation. | |
| Enclosing [UCAN] revocation offers a mechanism to revoke authorization that [authority] MAY have given to another principal to revoke [UCAN]s on their behalf. |
Gozala
commented
Jan 22, 2024
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Gozala
added a commit
that referenced
this pull request
Jan 22, 2024
Based on #102 --------- Co-authored-by: Alan Shaw <alan.shaw@protocol.ai> Co-authored-by: Benjamin Goering <171782+gobengo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document UCAN spec extensions we use and assume. Based on #31