Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repo): clarify how to version pin rulesets #2039

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

jamietanna
Copy link
Contributor

As noted in #2022, the version pinning can only be done using
package.jsons, not the extends rule.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Screenshots

N/A

Additional context

N/A

@jamietanna jamietanna changed the title Update docs to clarify how to version pin rulesets docs(repo): clarify how to version pin rulesets Jan 26, 2022
As noted in stoplightio#2022, the version pinning can only be done using
`package.json`s, not the `extends` rule.
@jamietanna jamietanna requested a review from P0lip January 27, 2022 11:55
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Thanks a lot for taking care of it.
Appreciate it a bunch ❤️

@P0lip P0lip enabled auto-merge (squash) January 27, 2022 12:04
@P0lip P0lip merged commit 6c47ea1 into stoplightio:develop Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants