fix(ruleset-migrator): resolve npm packages correctly #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
fix/ruleset-migrator/node-resolution
branch
from
59d873d to
9468469
Compare
P0lip
force-pushed
the
fix/ruleset-migrator/node-resolution
branch
from
65ae608 to
5deeba8
Compare
jamietanna
reviewed
Jan 19, 2022
| expect(isPackageImport(input)).toBe(true); | ||
| }); | ||
|
|
||
| it.each(['', '/nimma/legacy', 'path', 'https://cdn.skypack.dev/@stoplight/spectral-core'])( |
There was a problem hiding this comment.
Is it worth also adding spectral:oas as an example here?
There was a problem hiding this comment.
could add it, though in reality isPackageImport is unlikely to ever receive stoplight:oas as it's being replaced with @stoplight/spectral-rulesets here https://github.com/stoplightio/spectral/blob/develop/packages/ruleset-migrator/src/transformers/extends.ts#L21
jamietanna
reviewed
Jan 19, 2022
stoplight-bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
# [@stoplight/spectral-ruleset-migrator-v1.7.2](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-v1.7.1...@stoplight/spectral-ruleset-migrator-v1.7.2) (2022-01-26) ### Bug Fixes * **ruleset-migrator:** resolve npm packages correctly ([#2022](#2022)) ([843e47c](843e47c))
|
🎉 This PR is included in version @stoplight/spectral-ruleset-migrator-v1.7.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
jamietanna
added a commit
to jamietanna/spectral
that referenced
this pull request
Jan 26, 2022
As noted in stoplightio#2022, the version pinning can only be done using `package.json`s, not the `extends` rule.
4 tasks
jamietanna
added a commit
to jamietanna/spectral
that referenced
this pull request
Jan 26, 2022
As noted in stoplightio#2022, the version pinning can only be done using `package.json`s, not the `extends` rule.
jamietanna
added a commit
to jamietanna/spectral
that referenced
this pull request
Jan 26, 2022
As noted in stoplightio#2022, the version pinning can only be done using `package.json`s, not the `extends` rule.
jamietanna
added a commit
to jamietanna/spectral
that referenced
this pull request
Jan 27, 2022
As noted in stoplightio#2022, the version pinning can only be done using `package.json`s, not the `extends` rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2019
Checklist
Does this PR introduce a breaking change?