Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use critical_section crate. #28

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Use critical_section crate. #28

merged 2 commits into from
Nov 23, 2023

Conversation

reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented Jun 14, 2022 •
edited
Loading

Switch to using critical_section crate.

@reitermarkus reitermarkus marked this pull request as ready for review August 23, 2022 23:12
@reitermarkus reitermarkus changed the title Fix CriticalSection. Use critical_section crate. Aug 23, 2022
@katyo
Copy link

katyo commented Feb 4, 2023

Actual versions of riscv crate isn't compatible with this crate, bacause &mut CriticalSection argument was removed from closure.
This PR solves it by removing potentially incompatible dependencies (cortex-m, riscv crates).

@Disasm
Copy link
Member

Disasm commented Nov 19, 2023

Hi! Could you rebase your PR and add a changelog entry?

@reitermarkus
Copy link
Contributor Author

@Disasm, PR is rebased.

@reitermarkus
Copy link
Contributor Author

@Disasm, I fixed the CI matrix.

Disasm
Disasm approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@Disasm Disasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Disasm Disasm merged commit 255b040 into stm32-rs:master Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disasm Disasm Disasm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @katyo @Disasm