revise: makes various improvements to the line_width rule
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claymcleod
force-pushed
the
fix/line_width
branch
3 times, most recently
from
26a6448 to
62b60dd
Compare
claymcleod
commented
Jul 18, 2024
claymcleod
commented
Jul 18, 2024
| message = "arriba.wdl:140:1: note[LineWidth]: line exceeds maximum width of 90" | ||
| permalink = "https://github.com/stjudecloud/workflows/blob/833b97fb582fe7d4f6df9d29a645d0289f1fc92e/tools/arriba.wdl/#L140" | ||
| message = "read_group.wdl:134:1: note[LineWidth]: line exceeds maximum width of 90" | ||
| permalink = "https://github.com/stjudecloud/workflows/blob/129060215443bbd1b67c4d3d149d48acdab90ef2/data_structures/read_group.wdl/#L134" |
There was a problem hiding this comment.
This is still going to exist until we implement the fix we discussed in Slack. That is probably the another PR in the future.
claymcleod
commented
Jul 18, 2024
| message = "deeptools.wdl:6:7: note[Todo]: remaining `TODO` item found" | ||
| permalink = "https://github.com/stjudecloud/workflows/blob/833b97fb582fe7d4f6df9d29a645d0289f1fc92e/tools/deeptools.wdl/#L6" | ||
| message = "arriba.wdl:147:1: note[LineWidth]: line exceeds maximum width of 90" | ||
| permalink = "https://github.com/stjudecloud/workflows/blob/129060215443bbd1b67c4d3d149d48acdab90ef2/tools/arriba.wdl/#L147" |
claymcleod
force-pushed
the
fix/line_width
branch
from
62b60dd to
0722cdd
Compare
claymcleod
commented
Jul 18, 2024
| @@ -89,8 +83,7 @@ impl Rule for LineWidthRule { | |||
| } | |||
|
|
|||
| fn description(&self) -> &'static str { | |||
| "Ensures that lines do not exceed a certain width. That width is currently set to 90 \ | |||
| characters." | |||
| "Ensures that lines do not exceed a certain width." | |||
There was a problem hiding this comment.
The default should be described in the explanation (which it is), so it can be removed here.
claymcleod
force-pushed
the
fix/line_width
branch
2 times, most recently
from
3586337 to
3169e52
Compare
claymcleod
changed the title
line_width ruleline_width rule
|
Explicitly, I don't think this needs a CHANGELOG.md entry, as just the internals of the rule changed (and not it's behavior or interface). |
claymcleod
force-pushed
the
fix/line_width
branch
from
3169e52 to
93f9af1
Compare
claymcleod
commented
Jul 18, 2024
| note[LineWidth]: line exceeds maximum width of 90 | ||
| ┌─ tests/lints/line-width/source.wdl:31:1 | ||
| │ | ||
| 31 │ ╭ command <<< |
There was a problem hiding this comment.
See the comment in the source text for this diagnostic.
claymcleod
requested review from
a-frantz,
peterhuene and
adthrasher
and removed request for
a-frantz
a-frantz
approved these changes
Jul 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to fix the
line_widthrule, I discovered that the problem was actually in the way we did excepting of rules. That's probably a PR for a different day, but I made some improvements to the rule in terms of conciseness that I'd like to go ahead and merge in.