-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
revise: makes various improvements to the
line_width rule
- Loading branch information
1 parent
5193f5f
commit 93f9af1
Showing
5 changed files
with
152 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| note[LineWidth]: line exceeds maximum width of 90 | ||
| ┌─ tests/lints/line-width/source.wdl:12:1 | ||
| │ | ||
| 12 │ this is going to be a really long line that is almost certainly going to be longer than the maximum line length I would hope / | ||
| │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| │ | ||
| = fix: split the line into multiple lines | ||
|
|
||
| note[LineWidth]: line exceeds maximum width of 90 | ||
| ┌─ tests/lints/line-width/source.wdl:14:1 | ||
| │ | ||
| 14 │ this line is also going to be very very very long just to trip up our maximum line lint / | ||
| │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| │ | ||
| = fix: split the line into multiple lines | ||
|
|
||
| note[LineWidth]: line exceeds maximum width of 90 | ||
| ┌─ tests/lints/line-width/source.wdl:31:1 | ||
| │ | ||
| 31 │ ╭ command <<< | ||
| 32 │ │ bin / | ||
| 33 │ │ this is going to be a really long line that is not going to trip up our maximum line lint because it is excepted / | ||
| 34 │ │ some other / | ||
| · │ | ||
| 37 │ │ options | ||
| 38 │ │ >>> | ||
| │ ╰───────^ | ||
| │ | ||
| = fix: split the line into multiple lines | ||
|
|
||
| note[LineWidth]: line exceeds maximum width of 90 | ||
| ┌─ tests/lints/line-width/source.wdl:49:1 | ||
| │ | ||
| 49 │ command <<< this is a task that has a very very very long command section on the first line. >>> | ||
| │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| │ | ||
| = fix: split the line into multiple lines | ||
|
|
||
| note[LineWidth]: line exceeds maximum width of 90 | ||
| ┌─ tests/lints/line-width/source.wdl:55:1 | ||
| │ | ||
| 55 │ # Here is a very very very very very very very very very long comment that should absolutely eclipse 90 characters. | ||
| │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| │ | ||
| = fix: split the line into multiple lines | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #@ except: DescriptionMissing, RuntimeSectionKeys | ||
| version 1.1 | ||
|
|
||
| task task_a { | ||
| meta {} | ||
| parameter_meta {} | ||
| input {} | ||
|
|
||
| command <<< | ||
| bin \ | ||
| this is going to be a really long line that is almost certainly going to be longer than the maximum line length I would hope \ | ||
| some other \ | ||
| this line is also going to be very very very long just to trip up our maximum line lint \ | ||
| shorter \ | ||
| options | ||
| >>> | ||
|
|
||
| output {} | ||
| runtime {} | ||
| } | ||
|
|
||
| task task_b { | ||
| meta {} | ||
| parameter_meta {} | ||
| input {} | ||
|
|
||
| # This except currently causes the entire command block to fail. | ||
| # That will be fixed in the future when we fix how excepting works. | ||
| #@ except: LineWidth | ||
| command <<< | ||
| bin \ | ||
| this is going to be a really long line that is not going to trip up our maximum line lint because it is excepted \ | ||
| some other \ | ||
| this line is also going to be very very very long but it will also not trip up our maximum line line because it is excepted \ | ||
| shorter \ | ||
| options | ||
| >>> | ||
|
|
||
| output {} | ||
| runtime {} | ||
| } | ||
|
|
||
| task task_c { | ||
| meta {} | ||
| parameter_meta {} | ||
| input {} | ||
|
|
||
| command <<< this is a task that has a very very very long command section on the first line. >>> | ||
|
|
||
| output {} | ||
| runtime {} | ||
| } | ||
|
|
||
| # Here is a very very very very very very very very very long comment that should absolutely eclipse 90 characters. |