Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically parse the error result field in sendTransaction #157

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Automatically parse the error result field in sendTransaction #157

merged 6 commits into from
Oct 9, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 6, 2023 •
edited
Loading

In particular,

-    errorResultXdr?: string;
+    errorResult?: xdr.TransactionResult;

The error result field, if present, will automatically be decoded.

Closes #128.

@Shaptic Shaptic requested a review from sreuland October 6, 2023 22:01
sreuland
sreuland reviewed Oct 6, 2023
View reviewed changes
src/server.ts Show resolved Hide resolved
sreuland
sreuland approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left one comment to consider including some test coverage.

@Shaptic Shaptic mentioned this pull request Oct 9, 2023
Merged
@Shaptic Shaptic merged commit ac06f2c into main Oct 9, 2023
4 checks passed
@Shaptic Shaptic deleted the decode-send-transaction branch October 9, 2023 20:25
@kalbroni7 kalbroni7 mentioned this pull request Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decode XDR structures wherever possible.
2 participants
@Shaptic @sreuland