chore: update ts bindings #973

chadoh · 2023-09-18T19:13:16Z

What

Update the typescript bindings with all the changes that landed in the futurenet-compatible smartdeploy branch since main stopped working with futurenet.

Why

Lots of good improvements and fixes are not yet in main, ~~including tests for the generated libraries.~~ _CI tests will be included in a future PR; reasonable time-sink exceeded for this one.

Closes: #996

Known limitations

The newly-added tests are not yet being exercised in CI; you can see the commit history for all the details of how we tried to work around this. At this point, we will:

wait for Manage history-archive http server with supervisor quickstart#507 to get merged & included in a published quickstart image
retry the bindings-ts.yml workflow, which was almost working except that friendbot was not starting properly when quickstart was run in CI (though it does start properly, even if a bit slowly, when quickstart is run locally)
after a basic run-tests-with-published-quickstart is working, the next step is to build a custom quickstart image using this repository's RPC version, and use that custom quickstart to run the integration tests. This might be able to be accomplished as described by ChatGPT here.

- Pin soroban-cli to latest commit from stellar/stellar-cli#973. This PR will be mergeable once a new quickstart image is released and we can verify that its tests pass. - New CLI's typescript-bindings-generated libraries export a `Contract` class, rather than a flat bag of functions. Instantiating these contracts is now taken care of in `shared/contracts.ts`, with code throughout the rest of the codebase referencing these instances. - Instantiating these classes required access to the `network` and `rpcUrl` used with the `initialize.sh` script. NextJS doesn't allow reading the files we already write (like `.soroban-example-dapp/network`), so for now I've also `echo`d relevant values to a `shared/config.json` file, which is hidden. This could probably be cleaned up in the future by putting all relevant settings in an `.env` file, and cleaning up the package.json scripts to use `dotenv cross-env` or similar.

@leighmcculloch

- Pin soroban-cli to latest commit from stellar/stellar-cli#973. This PR will be mergeable once a new quickstart image is released and we can verify that its tests pass. - Update the contract's SDK version - Copy in abundance source from token contract at "Changes for the next release," stellar/soroban-examples#277. Note that I did not author most of the changes in the contracts/abundance folder. I only copied in the changes originally authored by @leighmcculloch, then updated for the single tweak that this abundance contract already had: 1. comments on the mint method; and 2. slightly modified mint behavior. - New CLI's typescript-bindings-generated libraries export a `Contract` class, rather than a flat bag of functions. Instantiating these contracts is now taken care of in `shared/contracts.ts`, with code throughout the rest of the codebase referencing these instances. - Instantiating these classes required access to the `network` and `rpcUrl` used with the `initialize.sh` script. NextJS doesn't allow reading the files we already write (like `.soroban-example-dapp/network`), so for now I've also `echo`d relevant values to a `shared/config.json` file, which is hidden. This could probably be cleaned up in the future by putting all relevant settings in an `.env` file, and cleaning up the package.json scripts to use `dotenv cross-env` or similar.

@leighmcculloch

- Pin soroban-cli to latest commit from stellar/stellar-cli#973. This PR will be mergeable once a new quickstart image is released and we can verify that its tests pass. - Update the contract's SDK version - Copy in abundance source from token contract at "Changes for the next release," stellar/soroban-examples#277. Note that I did not author most of the changes in the contracts/abundance folder. I only copied in the changes originally authored by @leighmcculloch, then updated for the single tweak that this abundance contract already had: 1. comments on the mint method; and 2. slightly modified mint behavior. - New CLI's typescript-bindings-generated libraries export a `Contract` class, rather than a flat bag of functions. Instantiating these contracts is now taken care of in `shared/contracts.ts`, with code throughout the rest of the codebase referencing these instances. - Instantiating these classes required access to the `network` and `rpcUrl` used with the `initialize.sh` script. NextJS doesn't allow reading the files we already write (like `.soroban-example-dapp/network`), so for now I've also `echo`d relevant values to a `shared/config.json` file, which is hidden. This could probably be cleaned up in the future by putting all relevant settings in an `.env` file, and cleaning up the package.json scripts to use `dotenv cross-env` or similar.

- copy abundance source from stellar/soroban-example-dapp#136 - pin soroban-cli from stellar/stellar-cli#973 - update everything else as needed

sreuland · 2023-10-03T18:43:24Z

@chadoh , rather than using quickstart image for server-side stack(core,rpc,etc) it looks like you could just add your new ts tests to the cli_test.go ?

Or in any case use it as a reference for how to run the server-side stack, as that test already spins up a standalone core, funded account, and an instance of rpc built from source code of current branch.

Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.

cmd/crates/soroban-spec-typescript/src/lib.rs

cmd/crates/soroban-spec-typescript/src/project_template/src/invoke.ts

cmd/crates/soroban-spec-typescript/ts-tests/package.json

cmd/crates/soroban-spec-typescript/ts-tests/src/test-custom-types.ts

cmd/crates/soroban-spec-typescript/ts-tests/src/util.ts

What ---- Update the typescript bindings with all the changes that landed in the futurenet-compatible `smartdeploy` branch since `main` stopped working with futurenet. Why --- Lots of good improvements and fixes are not yet in `main`, ~including tests for the generated libraries.~ _CI tests will be included in a future PR; reasonable time-sink exceeded for this one. Closes: stellar#996 Known limitations ----------------- The newly-added tests are not yet being exercised in CI; you can see the commit history for all the details of how we tried to work around this. At this point, we will: - wait for stellar/quickstart#507 to get merged & included in a published quickstart image - retry the `bindings-ts.yml` workflow, which was almost working except that friendbot was not starting properly when quickstart was run _in CI_ (though it does start properly, even if a bit slowly, when quickstart is run locally) - after a basic run-tests-with-published-quickstart is working, the next step is to build a custom quickstart image using _this repository's_ RPC version, and use that custom quickstart to run the integration tests. This might be able to be accomplished [as described by ChatGPT here](https://chat.openai.com/share/0f355fbe-93b9-4c8d-9c12-7f54846134bd).

Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.

* chore: update ts bindings What ---- Update the typescript bindings with all the changes that landed in the futurenet-compatible `smartdeploy` branch since `main` stopped working with futurenet. Why --- Lots of good improvements and fixes are not yet in `main`, ~including tests for the generated libraries.~ _CI tests will be included in a future PR; reasonable time-sink exceeded for this one. Closes: stellar#996 Known limitations ----------------- The newly-added tests are not yet being exercised in CI; you can see the commit history for all the details of how we tried to work around this. At this point, we will: - wait for stellar/quickstart#507 to get merged & included in a published quickstart image - retry the `bindings-ts.yml` workflow, which was almost working except that friendbot was not starting properly when quickstart was run _in CI_ (though it does start properly, even if a bit slowly, when quickstart is run locally) - after a basic run-tests-with-published-quickstart is working, the next step is to build a custom quickstart image using _this repository's_ RPC version, and use that custom quickstart to run the integration tests. This might be able to be accomplished [as described by ChatGPT here](https://chat.openai.com/share/0f355fbe-93b9-4c8d-9c12-7f54846134bd). * build: bump delta for flaky test * build: increase deltas in cli simulation test --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev> Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>

* chore: update ts bindings What ---- Update the typescript bindings with all the changes that landed in the futurenet-compatible `smartdeploy` branch since `main` stopped working with futurenet. Why --- Lots of good improvements and fixes are not yet in `main`, ~including tests for the generated libraries.~ _CI tests will be included in a future PR; reasonable time-sink exceeded for this one. Closes: #996 Known limitations ----------------- The newly-added tests are not yet being exercised in CI; you can see the commit history for all the details of how we tried to work around this. At this point, we will: - wait for stellar/quickstart#507 to get merged & included in a published quickstart image - retry the `bindings-ts.yml` workflow, which was almost working except that friendbot was not starting properly when quickstart was run _in CI_ (though it does start properly, even if a bit slowly, when quickstart is run locally) - after a basic run-tests-with-published-quickstart is working, the next step is to build a custom quickstart image using _this repository's_ RPC version, and use that custom quickstart to run the integration tests. This might be able to be accomplished [as described by ChatGPT here](https://chat.openai.com/share/0f355fbe-93b9-4c8d-9c12-7f54846134bd). * build: bump delta for flaky test * build: increase deltas in cli simulation test --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev> Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>

Add tests from AhaLabs#11 which didn't make it into #973 due to the quickstart image not starting properly in CI. Adding this directly to #973 was costing too much time. We can troubleshoot quickstart issues here.

Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.

@leighmcculloch

- Pin soroban-cli to latest commit from stellar/stellar-cli#973. This PR will be mergeable once a new quickstart image is released and we can verify that its tests pass. - Update the contract's SDK version - Copy in abundance source from token contract at "Changes for the next release," stellar/soroban-examples#277. Note that I did not author most of the changes in the contracts/abundance folder. I only copied in the changes originally authored by @leighmcculloch, then updated for the single tweak that this abundance contract already had: 1. comments on the mint method; and 2. slightly modified mint behavior. - New CLI's typescript-bindings-generated libraries export a `Contract` class, rather than a flat bag of functions. Instantiating these contracts is now taken care of in `shared/contracts.ts`, with code throughout the rest of the codebase referencing these instances. - Instantiating these classes required access to the `network` and `rpcUrl` used with the `initialize.sh` script. NextJS doesn't allow reading the files we already write (like `.soroban-example-dapp/network`), so for now I've also `echo`d relevant values to a `shared/config.json` file, which is hidden. This could probably be cleaned up in the future by putting all relevant settings in an `.env` file, and cleaning up the package.json scripts to use `dotenv cross-env` or similar.

Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.

Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`

* Add tests from AhaLabs#11 which didn't make it into #973 due to the quickstart image not starting properly in CI. * Update for latest changes from `soroban config identity` to `soroban keys`

chadoh mentioned this pull request Sep 19, 2023

build: update for preview 11 stellar/soroban-example-dapp#136

Merged

chadoh added a commit to AhaLabs/soroban-dapps-challenge that referenced this pull request Sep 20, 2023

build: update for preview 11

826d004

- copy abundance source from stellar/soroban-example-dapp#136 - pin soroban-cli from stellar/stellar-cli#973 - update everything else as needed

chadoh force-pushed the chore/bindings_udate branch from 74e3b90 to c7fb7e0 Compare September 24, 2023 16:00

willemneal force-pushed the chore/bindings_udate branch from c7fb7e0 to af9ff06 Compare September 27, 2023 16:28

chadoh force-pushed the chore/bindings_udate branch from b7e2eca to 39bb550 Compare September 28, 2023 11:22

sreuland mentioned this pull request Oct 4, 2023

CLI: integration test, ts bindings #996

Closed

chadoh force-pushed the chore/bindings_udate branch 7 times, most recently from 170a796 to 15031c8 Compare October 9, 2023 15:22

chadoh marked this pull request as ready for review October 9, 2023 15:22

chadoh force-pushed the chore/bindings_udate branch from 55ef601 to 9ec6baf Compare October 9, 2023 19:06

chadoh mentioned this pull request Oct 9, 2023

Test TypeScript Bindings in CI AhaLabs/stellar-cli#15

Closed

1 task

Shaptic reviewed Oct 9, 2023

View reviewed changes

kalepail mentioned this pull request Oct 11, 2023

TypeError: XDR Read Error: invalid XDR contract typecast - source buffer not entirely consumed stellar/js-soroban-client#162

Open

chadoh force-pushed the chore/bindings_udate branch 2 times, most recently from bff2f5c to 486fca1 Compare October 16, 2023 17:15

chadoh force-pushed the chore/bindings_udate branch from 486fca1 to 779f04c Compare October 16, 2023 18:06

chadoh and others added 3 commits October 16, 2023 15:23

build: bump delta for flaky test

91c21c5

Merge branch 'main' into chore/bindings_udate

0b6dfd7

build: increase deltas in cli simulation test

de7aaf5

tsachiherman approved these changes Oct 17, 2023

View reviewed changes

tsachiherman merged commit b15f0da into stellar:main Oct 17, 2023
22 checks passed

chadoh mentioned this pull request Oct 19, 2023

chore(bindings-ts): update to latest stellar-sdk & typescript; test in CI #1037

Merged

chadoh mentioned this pull request Oct 19, 2023

chore: update ts bindings (#973) #1038

Merged

willemneal deleted the chore/bindings_udate branch October 20, 2023 21:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update ts bindings #973

chore: update ts bindings #973

chadoh commented Sep 18, 2023 •

edited

Loading

sreuland commented Oct 3, 2023

chore: update ts bindings #973

chore: update ts bindings #973

Conversation

chadoh commented Sep 18, 2023 • edited Loading

What

Why

Known limitations

sreuland commented Oct 3, 2023

chadoh commented Sep 18, 2023 •

edited

Loading