Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix for bug that occurs when splitting single-element bins, use defau…
…lt BoTorch kernel for BAxUS. (pytorch#2165) Summary: This commit does two things: First, it fixes a bug that occurs when trying to split a bin with a single element. Also, we now use the default BoTorch Matern kernel instead of using MLE and lengthscale constraints. <!-- Thank you for sending the PR! We appreciate you spending the time to make BoTorch better. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to BoTorch here: https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md --> ## Motivation I received a bug report via email for a slightly different benchmark setup that affects the code in the BAxUS tutorial. The bug occurs in cases when, after splitting, a bin contains only a single element, but other bins contain more than one element. In that case, the previous code attempted to split that bin which later caused an error. This commit fixes this bug and, at the same time, removes the custom Matern kernel we used in the previous version. The kernel does not improve performance but adds overhead to the tutorial. ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: pytorch#2165 Test Plan: I tested this version on multiple benchmark setups to ensure this bug is fixed. ## Related PRs Initial PR for BAxUS tutorial: pytorch#1559 Reviewed By: SebastianAment Differential Revision: D52718499 Pulled By: saitcakmak fbshipit-source-id: 7b2af5ec988406b3e482baa3ddf9f0becc17e45c
- Loading branch information