Fix for bug that occurs when splitting single-element bins, use default BoTorch kernel for BAxUS. #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt BoTorch kernel for BAxUS. This commit does two things: First, it fixes bug that occurs when trying to split a bin with a single element. Also, we now use the default BoTorch Matern kernel instead of using MLE and lengthscale constraints.
facebook-github-bot
added
the
CLA Signed
saitcakmak
approved these changes
Jan 12, 2024
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@saitcakmak merged this pull request in 26d79bc. |
stefanpricopie
pushed a commit
to stefanpricopie/botorch
that referenced
this pull request
Feb 27, 2024
…lt BoTorch kernel for BAxUS. (pytorch#2165) Summary: This commit does two things: First, it fixes a bug that occurs when trying to split a bin with a single element. Also, we now use the default BoTorch Matern kernel instead of using MLE and lengthscale constraints. <!-- Thank you for sending the PR! We appreciate you spending the time to make BoTorch better. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to BoTorch here: https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md --> ## Motivation I received a bug report via email for a slightly different benchmark setup that affects the code in the BAxUS tutorial. The bug occurs in cases when, after splitting, a bin contains only a single element, but other bins contain more than one element. In that case, the previous code attempted to split that bin which later caused an error. This commit fixes this bug and, at the same time, removes the custom Matern kernel we used in the previous version. The kernel does not improve performance but adds overhead to the tutorial. ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: pytorch#2165 Test Plan: I tested this version on multiple benchmark setups to ensure this bug is fixed. ## Related PRs Initial PR for BAxUS tutorial: pytorch#1559 Reviewed By: SebastianAment Differential Revision: D52718499 Pulled By: saitcakmak fbshipit-source-id: 7b2af5ec988406b3e482baa3ddf9f0becc17e45c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does two things:
First, it fixes a bug that occurs when trying to split a bin with a single element.
Also, we now use the default BoTorch Matern kernel instead of using MLE and lengthscale constraints.
Motivation
I received a bug report via email for a slightly different benchmark setup that affects the code in the BAxUS tutorial. The bug occurs in cases when, after splitting, a bin contains only a single element, but other bins contain more than one element. In that case, the previous code attempted to split that bin which later caused an error. This commit fixes this bug and, at the same time, removes the custom Matern kernel we used in the previous version. The kernel does not improve performance but adds overhead to the tutorial.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I tested this version on multiple benchmark setups to ensure this bug is fixed.
Related PRs
Initial PR for BAxUS tutorial: #1559