Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21389] fix: display correct amount without rounding #22272

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #21389

Summary

Display correct amount without rounding

Areas that may be impacted

  • Send and Bridge

Steps to test

  1. Recover a user with available assets that require rounding (e.g., 1.149 DAI in my case).
  2. Go to the routes generation page in the send or bridge flow.
  3. Check the max value displayed.

Before

Result

Simulator.Screen.Recording.-.iPhone.13.-.2025-03-10.at.18.53.03.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri added the wallet-core Issues for mobile wallet team label Mar 10, 2025
@mohsen-ghafouri mohsen-ghafouri self-assigned this Mar 10, 2025
@mohsen-ghafouri mohsen-ghafouri force-pushed the fix/rounding-send-bridge branch from bad2682 to f0fbdeb Compare March 10, 2025 16:00
@status-im-auto
Copy link
Member

status-im-auto commented Mar 10, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
f0fbdeb #2 2025-03-10 16:03:32 ~2 min ios 📄log
✔️ f0fbdeb #2 2025-03-10 16:05:15 ~4 min tests 📄log
✔️ f0fbdeb #2 2025-03-10 16:07:48 ~7 min android-e2e 🤖apk 📲
✔️ f0fbdeb #2 2025-03-10 16:08:14 ~7 min android 🤖apk 📲
f0fbdeb #3 2025-03-10 16:16:37 ~2 min ios 📄log
ca0ecca #4 2025-03-10 16:39:09 ~2 min ios 📄log
✔️ ca0ecca #3 2025-03-10 16:41:13 ~4 min tests 📄log
✔️ ca0ecca #3 2025-03-10 16:43:40 ~7 min android 🤖apk 📲
✔️ ca0ecca #3 2025-03-10 16:44:22 ~8 min android-e2e 🤖apk 📲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet-core Issues for mobile wallet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect max value rounding on routes generation page (Bridge and Send pages)
2 participants