-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect max value rounding on routes generation page (Bridge and Send pages) #21389
Comments
@VolodLytvynenko, I'm closing this issue since it is related to interface that we don't have anymore. |
hi @vkjr This issue is related to max value rounding, which still exists in our new UI and behaves the same way as when the issue was created. I've reopened the issue. |
@shivekkhurana Could you please prioritize whether we should address the max value now? I believe we should, since the item with the max ETH value was included in 2.33.1. I’ve moved the issue to 2.33.1, so please prioritize accordingly. Thanks! |
2.33.1 sounds better. |
Steps:
Actual result:
The max value is rounded up (e.g., 1.149 DAI is rounded to 1.15), confusing the user. So, when the user enters 0.96, they receive an incorrect error message: "Fee greater than estimated."
Expected result:
The max value should be rounded down (e.g., to 1.14) to avoid confusing the user about the sum he owns
OS:
IOS, Android
Devices:
The text was updated successfully, but these errors were encountered: