Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect max value rounding on routes generation page (Bridge and Send pages) #21389

Open
VolodLytvynenko opened this issue Oct 4, 2024 · 4 comments · May be fixed by #22272
Open

Incorrect max value rounding on routes generation page (Bridge and Send pages) #21389

VolodLytvynenko opened this issue Oct 4, 2024 · 4 comments · May be fixed by #22272
Assignees
Labels
lead-review-required qa-reviewed validation wallet: Send all issues for the send page of the wallet wallet-core Issues for mobile wallet team
Milestone

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Oct 4, 2024

Steps:

  1. Recover a user with available assets that require rounding (e.g., 1.149 DAI in my case).
  2. Go to the routes generation page in the send or bridge flow.
  3. Check the max value displayed.

Actual result:

The max value is rounded up (e.g., 1.149 DAI is rounded to 1.15), confusing the user. So, when the user enters 0.96, they receive an incorrect error message: "Fee greater than estimated."

Image

Expected result:

The max value should be rounded down (e.g., to 1.14) to avoid confusing the user about the sum he owns

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17
@VolodLytvynenko VolodLytvynenko added bug wallet: Send all issues for the send page of the wallet labels Oct 4, 2024
@VolodLytvynenko VolodLytvynenko added this to the 2.32.0 Beta milestone Oct 4, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
@churik churik added wallet-core Issues for mobile wallet team and removed medium-prio labels Oct 14, 2024
@churik churik modified the milestones: 2.32.0, 2.33.0 Nov 25, 2024
@vkjr vkjr self-assigned this Jan 2, 2025
@churik churik modified the milestones: 2.33.0, 2.34.0 Jan 27, 2025
@vkjr
Copy link
Contributor

vkjr commented Feb 24, 2025

@VolodLytvynenko, I'm closing this issue since it is related to interface that we don't have anymore.
Please reopen if you have any objections.

@VolodLytvynenko
Copy link
Contributor Author

@VolodLytvynenko, I'm closing this issue since it is related to interface that we don't have anymore. Please reopen if you have any objections.

hi @vkjr This issue is related to max value rounding, which still exists in our new UI and behaves the same way as when the issue was created.

I've reopened the issue.

@churik churik moved this from Done to Backlog in Status Desktop/Mobile Board Mar 6, 2025
@churik
Copy link
Member

churik commented Mar 6, 2025

@shivekkhurana Could you please prioritize whether we should address the max value now?

I believe we should, since the item with the max ETH value was included in 2.33.1.

I’ve moved the issue to 2.33.1, so please prioritize accordingly. Thanks!

@shivekkhurana
Copy link
Contributor

2.33.1 sounds better.

@shivekkhurana shivekkhurana assigned mohsen-ghafouri and unassigned vkjr Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-review-required qa-reviewed validation wallet: Send all issues for the send page of the wallet wallet-core Issues for mobile wallet team
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

6 participants