🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully #20799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (77)
|
shivekkhurana
force-pushed
the
shivekkhurana/wc-dapps-list-testnet-filter
branch
5 times, most recently
from
b6c63a3
to
348da17
Compare
shivekkhurana
changed the title
shivekkhurana
force-pushed
the
shivekkhurana/wc-dapps-list-testnet-filter
branch
from
0eceaf0
to
ca96fd5
Compare
57% of end-end tests have passedFailed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
|
alwx
requested changes
Jul 19, 2024
src/status_im/contexts/wallet/wallet_connect/responding_events.cljs
Outdated
Show resolved
Hide resolved
clauxx
reviewed
Jul 19, 2024
src/status_im/contexts/wallet/wallet_connect/session_proposal/view.cljs
Outdated
Show resolved
Hide resolved
shivekkhurana
force-pushed
the
shivekkhurana/wc-dapps-list-testnet-filter
branch
2 times, most recently
from
8404cb2
to
db47eaf
Compare
clauxx
approved these changes
Jul 23, 2024
|
@pavloburykh @qoqobolo the PR is ready for testing |
alwx
requested changes
Jul 24, 2024
shivekkhurana
force-pushed
the
shivekkhurana/wc-dapps-list-testnet-filter
branch
from
b3beff7
to
99dabb8
Compare
|
@shivekkhurana please take a look at the issues ISSUE 1
|
shivekkhurana
force-pushed
the
shivekkhurana/wc-dapps-list-testnet-filter
branch
from
34a26b3
to
e5a878b
Compare
This PR has evolved over time. It mainly fixes connected dapps list, and other things just creeped in. |
qoqobolo
added
test cases required
skip-manual-qa
and removed
Tested - Issues
request-manual-qa
labels
J-Son89
pushed a commit
that referenced
this pull request
Jul 26, 2024
…requests gracefully (#20799) * 🥅 Filter connected dapps based on testnet mode - Fixes #20794 * 🥅 Remove map, just filter * 💿 Rebase * ❌ Remove greedy fetch * 🙅♀️ Properly reject proposals and requests * 🎗️ Remove newline and move `set` - `set` was applied at the wrong place here * ✏️ Address review comments * 👀 Read proposal to reject from state *◀️ Bring back network filtering * 🧹 Cleanup * ✏️ Move comment around * 🎣 Use filter operable accounts helper * ➕ Add back events deleted during rebase * 🧰 Fix Issue 2, Testnet sessions not visible * 🖊️ Fix lint * 🔗 Make testnet filtering more explicit * 🥢 Use union instead of two subsets call * ✏️ Fix lint * 🔇 Undo changes that creeped in an unrelated ns
ilmotta
pushed a commit
that referenced
this pull request
Jul 28, 2024
…requests gracefully (#20799) * 🥅 Filter connected dapps based on testnet mode - Fixes #20794 * 🥅 Remove map, just filter * 💿 Rebase * ❌ Remove greedy fetch * 🙅♀️ Properly reject proposals and requests * 🎗️ Remove newline and move `set` - `set` was applied at the wrong place here * ✏️ Address review comments * 👀 Read proposal to reject from state *◀️ Bring back network filtering * 🧹 Cleanup * ✏️ Move comment around * 🎣 Use filter operable accounts helper * ➕ Add back events deleted during rebase * 🧰 Fix Issue 2, Testnet sessions not visible * 🖊️ Fix lint * 🔗 Make testnet filtering more explicit * 🥢 Use union instead of two subsets call * ✏️ Fix lint * 🔇 Undo changes that creeped in an unrelated ns
This was referenced Jul 29, 2024
Closed
ilmotta
added a commit
that referenced
this pull request
Jul 30, 2024
Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #20794 (Not to be marked as fixed until tested)
Should fix #20693 (comment)
Fix Connected Dapps screen to respect Testnet mode selection in app
Approach: There are allowed chains in the session. If the app is on mainnet, we show only the sessions where allowed chains are mainnet.
Otherwise, we show all testnet sessions (ie Goerli and Sepolia both will show up). This is in accordance with how our app works.
--
Implements: #20362 (Not to be marked as fixed until tested)
Reject session proposal (on WC) gracefully via UI
Reject session proposal (on WC) if networks are not supported (ie user is on testnet or dapp connected on a different chain all together)
Reject session requests automatically (on WC) if app switched modes or accounts
USER_REJECTED_CHAINS