-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display group chat system message using new ui #20787
Conversation
Jenkins BuildsClick to see older builds (41)
|
7ec6d94
to
3e8567e
Compare
3e8567e
to
a291c66
Compare
a291c66
to
cb06a5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few minor suggestions, but from a superficial look, the UI looks good @jo-mut.
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
cb06a5b
to
0182dab
Compare
0182dab
to
9eb486e
Compare
71% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
9eb486e
to
b1410f0
Compare
86% of end-end tests have passed
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (6)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
b1410f0
to
cad6087
Compare
82629c1
to
dcdcfe0
Compare
Hi @jo-mut ! New UI looks much prettier! Just a little issue: ISSUE 1: The comma is moved to the second line Expected result: comma should not be moved alone to the next line |
thank you @mariia-skrypnyk. Let me see how to fix this one |
@mariia-skrypnyk how do you feel about merging this like it is and fixing issue as a followup, as it indeed much better? |
@jo-mut merge this one, yeey :) |
ac8fe1a
to
14414a6
Compare
14414a6
to
8c3aa62
Compare
Revisions from develop: - 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902) - 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721) - 8c2d539 Enabling WalletConnect feature flag (#20906) - 67c83b1 fix(wallet): remove edit routes button in bridging (#20874) - 11a84ba feat(wallet): disable complex routing (#20901) - 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846) - 4586f80 Add toggle in advanced settings for mobile data - 55c620e fix: create password for small screen (#20645) - 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862) - 9065395 chore(settings): Disable telemetry option (#20881) - d27ab75 fix_:display group message using the new ui (#20787) - c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683) - 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845) - a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888) - a671c70 fix broken screen and navigation when syncing fails (#20887) - a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799) - 2e9fa22 feat: wallet router v2 (#20631) - 737d8c4 rename sub to fix error when requesting to join community (#20868) - 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883) - c1d2d44 perf: Fix app freeze after login (#20729) - 0fed811 e2e: updated testnet switching and added one test into smoke - 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854) - be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875) - eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873) - fe54a25 fix: not clearing network & web3-wallet on logout (#20886) - 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836) - 2ffbdac WalletConnect show expired toast (#20857) - 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867) - ff88049 Fix WalletConnect header alignment on Android (#20860) - cee2124 WalletConnect no internet edge-cases (#20826) - 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825) - 4989c92 fix_: Adding own address as saved addresses (#20839)
fixes #20488
Summary
This pr. displays group chat system message using the new ui
Before and after screenshots comparison
Figma
https://www.figma.com/design/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=11522-138410&t=nzRl5xrbCFgAZrgX-4
status: ready