-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn phyloseq from an Imports to a Suggests #171
Conversation
…>5 seconds to run
…hese functions are taking >5 seconds to check)
…aluate chunks based on phyloseq availability, adding a second vignette that doesn't use phyloseq
…me of new vignette
… phyloseq objects are created
… that uses phyloseq. A few edits to the vignette that does not use phyloseq.
Suggest phyloseq
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 94.12% 93.36% -0.77%
==========================================
Files 34 35 +1
Lines 1158 1176 +18
==========================================
+ Hits 1090 1098 +8
- Misses 68 78 +10 ☔ View full report in Codecov by Sentry. |
This pull request does several things:
-it adds new data, specifically the sample data, otu tables, and in some cases taxonomy tables, that make up phyloseq objects used for tests and the vignette
-it removes all phyloseq objects from the data folder of the package
-it updates all examples so that they run without phyloseq and without phyloseq data objects (for
bbdml()
,differentialTest()
, andcontrastsTest()
, there are examples using phyloseq wrapped in\donotrun{}
tags)-it takes all tests that use phyloseq and puts them into a single testing file, where the phyloseq objects are created from the dataframes stored in the package
-it creates a new vignette that doesn't use phyloseq (with most of the same analyses as the original vignette that does use phyloseq)