Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn phyloseq from an Imports to a Suggests #171

Closed
wants to merge 15 commits into from

Conversation

svteichman
Copy link
Collaborator

This pull request does several things:

-it adds new data, specifically the sample data, otu tables, and in some cases taxonomy tables, that make up phyloseq objects used for tests and the vignette
-it removes all phyloseq objects from the data folder of the package
-it updates all examples so that they run without phyloseq and without phyloseq data objects (for bbdml(), differentialTest(), and contrastsTest(), there are examples using phyloseq wrapped in \donotrun{} tags)
-it takes all tests that use phyloseq and puts them into a single testing file, where the phyloseq objects are created from the dataframes stored in the package
-it creates a new vignette that doesn't use phyloseq (with most of the same analyses as the original vignette that does use phyloseq)

…hese functions are taking >5 seconds to check)
…aluate chunks based on phyloseq availability, adding a second vignette that doesn't use phyloseq
… that uses phyloseq. A few edits to the vignette that does not use phyloseq.
@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (779de75) 94.12% compared to head (cfc6ba6) 93.36%.

❗ Current head cfc6ba6 differs from pull request most recent head cc47207. Consider uploading reports for the commit cc47207 to get more accurate results

Files Patch % Lines
R/contrastsTest.R 35.71% 9 Missing ⚠️
R/differentialTest.R 87.50% 3 Missing ⚠️
R/clean_taxa_names.R 85.71% 1 Missing ⚠️
R/convert_phylo.R 87.50% 1 Missing ⚠️
R/otu_to_taxonomy.R 85.71% 1 Missing ⚠️
R/warn_phyloseq.R 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   94.12%   93.36%   -0.77%     
==========================================
  Files          34       35       +1     
  Lines        1158     1176      +18     
==========================================
+ Hits         1090     1098       +8     
- Misses         68       78      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svteichman svteichman closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants