Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Laravel Pint: Use the default for nullable_type_declaration_for_default_null_value #9181

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Dec 11, 2023

This PR follows on from #9126 last week where an update in Laravel Pint introduced a syntax change to method signatures throughout the codebase.

We initially thought this was a breaking change so we reverted the value for the updated setting (nullable_type_declaration_for_default_null_value) to the previous default.

However, after some additional testing, we found it to not be breaking so this PR removes our override of the setting and runs Laravel Pint.

…fault_null_value`

We added this to the Pint config last week (#9126) but its no longer needed.
@jasonvarga jasonvarga merged commit f104d0b into 4.x Dec 11, 2023
37 checks passed
@jasonvarga jasonvarga deleted the use-new-pint-default branch December 11, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants