[4.x] Laravel Pint: Revert nullable_type_declaration_for_default_null_value default
#9126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 41b4476.
…behaviour Changing back after the default changed in Pint: laravel/pint#236
duncanmcclean
changed the title
nullable_type_declaration_for_default_null_value to the old default
duncanmcclean
changed the title
nullable_type_declaration_for_default_null_value to the old defaultnullable_type_declaration_for_default_null_value default
jasonvarga
changed the title
nullable_type_declaration_for_default_null_value defaultnullable_type_declaration_for_default_null_value default
|
For context, we reverted this rule because it could be a breaking change if someone overrides the class. If a parent method has a |
|
I was wrong. It's not a breaking change. I was missing a |
duncanmcclean
added a commit
that referenced
this pull request
Dec 11, 2023
…fault_null_value` We added this to the Pint config last week (#9126) but its no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts the config value for
nullable_type_declaration_for_default_null_valueafter the default was changed in the latest Laravel Pint release: (v1.13.7).