PHP 8 #2944
Merged
PHP 8 #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Nov 30, 2020
Merged
jasonvarga
force-pushed
the
feature/php8
branch
from
f73d09f to
e658f60
Compare
i.e. I ran `composer update composer/composer -W` The latest dev version of composer allows it to be installed on php8. composer/composer#9523 (comment)
…n ... Right now it just scraps everything before the first opening brace on a new line.
laravel/framework#35535 Might be better to bump the Laravel 8 min requirement, but our test matrix overwrites it and I don't really want to mess with that just yet.
keep the names because we have required checks based on the names. PR checks would need to be re-triggered
jasonvarga
force-pushed
the
feature/php8
branch
from
e658f60 to
6451c97
Compare
I noticed that it was still symlinking. It was because this wasn't committed. Also, because its no longer symlinked, the path should within vendor, not the original location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on dependencies to be updated for PHP 8:
mrclay/minify (PR)No longer needed.Related tasks:
phprequirement to include^8.0onstatamic/statamic(PR)statamic/starter-kit-cool-writingsstatamic/starter-kit-doogie-browserstatamic/starter-kit-starters-creek