This repository has been archived by the owner on Jan 28, 2022. It is now read-only.
PHP 8 #40
Merged
PHP 8 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How cool is that! Thanks Jason! Amazing contributon. 💖 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP 8.
Not quite ready yet. It's waiting on PHP 8 support to be added to mrclay/minify#684I haven't committed changes to composer.lock yet because I had to use a local composer repo to test mrclay/minify.
Rather than update mrclay/minify, which seems to have a bunch of dependency issues itself, I've removed it entirely and replaced it with a single class that mimics the functionality being used.
It's basically just the
processmethod here. I've cherry picked only the bits that make the test suite pass. Any differences are what php cs fixer required.Also, like ueberdosis/prosemirror-to-html#44, I've added
lowestandhighestto the test matrix.