Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preventing box values from being const-folded. #5416

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Preventing box values from being const-folded. #5416

merged 1 commit into from
Apr 14, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Apr 13, 2024 •
edited by spapinistarkware
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is Reviewable

This was referenced Apr 13, 2024
Merged
Merged
@orizi orizi requested a review from gilbens-starkware April 13, 2024 07:03
@orizi orizi linked an issue Apr 13, 2024 that may be closed by this pull request
bug: Program creating Nullable<Box<u32>> panics during execution #5411
Closed
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from d93953e to 12358f4 Compare April 13, 2024 08:08
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch from c56c472 to 9459bb8 Compare April 13, 2024 08:08
This was referenced Apr 13, 2024
Merged
Merged
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from 12358f4 to ebea99c Compare April 14, 2024 08:34
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch 2 times, most recently from 176e287 to d3730d8 Compare April 14, 2024 09:14
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from ebea99c to c10d2ec Compare April 14, 2024 09:14
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch from d3730d8 to c0819df Compare April 14, 2024 09:23
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from c10d2ec to eda0902 Compare April 14, 2024 09:23
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch from c0819df to a95bc09 Compare April 14, 2024 09:29
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from eda0902 to 99961f8 Compare April 14, 2024 09:29
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch from a95bc09 to 696f476 Compare April 14, 2024 10:50
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch 2 times, most recently from 3bc9341 to b308fac Compare April 14, 2024 11:27
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch 2 times, most recently from 244296d to b17a9d3 Compare April 14, 2024 11:44
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from b308fac to 8ae2887 Compare April 14, 2024 11:44
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch from b17a9d3 to e6b19aa Compare April 14, 2024 11:45
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch 2 times, most recently from af5a735 to 3bb90f4 Compare April 14, 2024 12:09
@orizi orizi force-pushed the pr/orizi/bounded-int/ec6469b5 branch from e6b19aa to 50f0be8 Compare April 14, 2024 12:09
@orizi orizi changed the base branch from pr/orizi/bounded-int/ec6469b5 to main April 14, 2024 12:43
@orizi orizi force-pushed the pr/orizi/bounded-int/96c96792 branch from 3bb90f4 to 13280f4 Compare April 14, 2024 12:43
gilbens-starkware
gilbens-starkware approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Apr 14, 2024
Merged via the queue into main with commit 91ba766 Apr 14, 2024
85 checks passed
@orizi orizi deleted the pr/orizi/bounded-int/96c96792 branch April 17, 2024 16:23
@bmmoore bmmoore mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Program creating Nullable<Box<u32>> panics during execution
2 participants
@orizi @gilbens-starkware