-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added require
util.
#5393
Added require
util.
#5393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 28 files at r1.
Reviewable status: 27 of 28 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @mkaput)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, to my eyes this does not bring significant improvements, but I want to enforce my opinion here. I would love just not to use it in the LS
Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @orizi)
crates/cairo-lang-language-server/src/lib.rs
line 1218 at r1 (raw file):
let syntax_db = db.upcast(); let (node, lookup_items) = get_node_and_lookup_items(db, file, position)?; require(node.kind(syntax_db) == SyntaxKind::TokenIdentifier)?;
Could you please revert this change in the LS code? I would like to eventually minimize source dependencies on compiler utils and other crates in my areas of interest :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*I do not want to enforce
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @orizi)
7a0b5d3
to
7b6cd4f
Compare
8ba6e06
to
248753f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 27 of 28 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @ilyalesokhin-starkware, and @mkaput)
crates/cairo-lang-language-server/src/lib.rs
line 1218 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
Could you please revert this change in the LS code? I would like to eventually minimize source dependencies on compiler utils and other crates in my areas of interest :/
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 28 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
248753f
to
266a217
Compare
0228fb4
to
5806045
Compare
fb05129
to
d9ec79e
Compare
5806045
to
373a9bc
Compare
d9ec79e
to
05fdb07
Compare
044bde7
to
d1ef438
Compare
05fdb07
to
4fccb64
Compare
c56c472
to
9459bb8
Compare
bcc180f
to
00a2ad3
Compare
00a2ad3
to
3cd9dc5
Compare
176e287
to
d3730d8
Compare
3cd9dc5
to
7ae1a03
Compare
d3730d8
to
c0819df
Compare
7ae1a03
to
55e53ce
Compare
c0819df
to
a95bc09
Compare
55e53ce
to
824c02e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 28 files at r1, 2 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
824c02e
to
f4c531b
Compare
696f476
to
244296d
Compare
f4c531b
to
adb2930
Compare
244296d
to
b17a9d3
Compare
adb2930
to
1476e34
Compare
b17a9d3
to
e6b19aa
Compare
1476e34
to
53d8cad
Compare
Used all around. commit-id:ec6469b5
e6b19aa
to
50f0be8
Compare
Used all around.
Stack:
require
util. #5393 ⬅This change is