Use views for the creating the temporary models in Delta tests #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
hovaesco
approved these changes
Jan 2, 2023
damian3031
approved these changes
Jan 2, 2023
|
I think this should be announced as a breaking change as it requires to upgrade to latest Trino version. |
This change affects only the tests - no productive code has been changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Now that there can be used Trino views in Delta Lake connector - see trinodb/trino#11763 - there is no need to set
views_enabledtofalsefor the temporary models in the tests.Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry