Skip to content

Commit

Permalink
Use views for the creating the temporary models in Delta tests
Browse files Browse the repository at this point in the history
  • Loading branch information
findinpath authored and mdesmet committed Jan 4, 2023
1 parent d06c8a8 commit 1e199ae
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,9 @@ class TestDeltaIncrementalMerge(TrinoIncrementalUniqueKey):
def project_config_update(self):
return {
"name": "incremental",
# TODO: remove `views_enabled` when https://github.com/trinodb/trino/pull/11763 is merged
"models": {
"+on_table_exists": "drop",
"+incremental_strategy": "merge",
"+views_enabled": False,
},
"seeds": {"incremental": {"seed": {"+column_types": {"some_date": "date"}}}},
}
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,9 @@ class TestDeltaOnSchemaChange(OnSchemaChangeBase):
def project_config_update(self):
return {
"name": "on_schema_change_delta",
# TODO: remove views_enabled when https://github.com/trinodb/trino/pull/11763 is merged
"models": {
"+on_table_exists": "drop",
"+incremental_strategy": "merge",
"+views_enabled": False,
},
}

Expand Down

0 comments on commit 1e199ae

Please sign in to comment.