Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(runtime): fix dockerize tag tuple typo #1251

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

tianweidut
Copy link
Member

Description

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working runtime🐌 labels Sep 20, 2022
@tianweidut tianweidut added this to the v0.3 milestone Sep 20, 2022
@tianweidut tianweidut self-assigned this Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1251 (2c33eed) into main (b7a536c) will increase coverage by 11.91%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1251       +/-   ##
=============================================
+ Coverage     73.79%   85.70%   +11.91%     
=============================================
  Files           287       62      -225     
  Lines         13312     7018     -6294     
  Branches        646        0      -646     
=============================================
- Hits           9824     6015     -3809     
+ Misses         3268     1003     -2265     
+ Partials        220        0      -220     
Flag Coverage Δ
controller ?
standalone 85.70% <ø> (+0.01%) ⬆️
unittests 85.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/model.py 92.91% <ø> (+0.02%) ⬆️
client/starwhale/base/view.py 83.75% <0.00%> (-0.21%) ⬇️
client/starwhale/api/_impl/model.py 91.51% <0.00%> (-0.11%) ⬇️
client/starwhale/base/bundle.py 91.97% <0.00%> (-0.06%) ⬇️
...va/ai/starwhale/mlops/domain/task/TaskService.java
.../ai/starwhale/mlops/domain/user/SaltGenerator.java
...le/mlops/api/protocol/swds/upload/UploadPhase.java
...i/starwhale/mlops/domain/system/SystemVersion.java
...whale/mlops/storage/s3/StorageAccessServiceS3.java
...lops/domain/job/step/status/StepStatusMachine.java
... and 224 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the fix/runtime-dockerize branch from c3897de to 2c33eed Compare September 20, 2022 08:06
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 31282d5 into star-whale:main Sep 20, 2022
@tianweidut tianweidut deleted the fix/runtime-dockerize branch September 20, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants