fix dockerize tag tuple typo

star-whale · Sep 20, 2022 · 2c33eed · 2c33eed
1 parent b7a536c
commit 2c33eed
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/client/starwhale/core/runtime/cli.py b/client/starwhale/core/runtime/cli.py
@@ -371,9 +371,9 @@ def _lock(
 )
 def _dockerize(
     uri: str,
-    tag: t.List[str],
+    tag: t.Tuple[str],
     push: bool,
-    platform: t.List[str],
+    platform: t.Tuple[str],
     dry_run: bool,
     use_starwhale_builder: bool,
     reset_qemu_static: bool,
@@ -383,5 +383,10 @@ def _dockerize(
     URI (str): Starwhale Runtime URI in the standalone instance
     """
     RuntimeTermView(uri).dockerize(
-        tag, push, platform, dry_run, use_starwhale_builder, reset_qemu_static
+        list(tag),
+        push,
+        list(platform),
+        dry_run,
+        use_starwhale_builder,
+        reset_qemu_static,
     )
diff --git a/client/starwhale/core/runtime/model.py b/client/starwhale/core/runtime/model.py
@@ -1067,7 +1067,7 @@ def _render_dockerignore() -> None:
             )
 
         def _build(_manifest: t.Dict[str, t.Any]) -> None:
-            _tags = tags or []
+            _tags = list(tags or [])
             _platforms = platforms or []
             _dc_image = _manifest["configs"].get("docker", {}).get("image")
             if _dc_image:

diff --git a/client/tests/core/test_runtime.py b/client/tests/core/test_runtime.py
@@ -873,7 +873,7 @@ def test_dockerize(self, m_check: MagicMock) -> None:
         assert f"--file {dockerfile_path}" in build_cmd
 
         RuntimeTermView(f"{name}/version/{version}").dockerize(
-            tags=[],
+            tags=("t1", "t2", "t3"),  # type: ignore
             push=False,
             platforms=[SupportArch.ARM64],
             dry_run=False,