Import workflow-kotlin-compose repo into the compose/ directory. #301

zach-klippenstein · 2021-02-04T21:35:10Z

As far as gradle are concerned, this is entirely separate from the main workflow gradle project. We might merge them later, but this PR does not attempt to do so.
Includes all commits from the compose repo (which includes some duplicates from the early workflow days – this is a little weird, but i don't think it's critical, and fixing that would be very difficult).
Merges the CODEOWNERs files.
The compose github actions configurations are already in their own file, so no merge conflict.
I have already transferred open issues over
Will push branches from compose to this repo so we can pick those up from where we left them.

Fixes #289.

See gradle/gradle#11308.

Add workaround for Nexus issue with sha256/512 checksums.

Remove unused JMH dependencies and configuration.

* zachklipp/cleanup-dependencies: Remove unused dependencies.

Upgrade workflow dependencies to latest version.

Duplicate of square/workflow#1146

Cleanup how ComposableViewFactory handles initial rendering.

`ComposeWorkflow` is like a `StatelessWorkflow`, but it has a special `render` method: it's a `@Composable` function, and it functions like the body of a `bindCompose` lambda where the rendering is just the workflow's props and a `Sink` accepting `OutputT`s.

* zachklipp/composeworkflow: Introduce ComposeWorkflow, a self-rendering Workflow.

This is the Compose analog to `WorkflowViewStub`, and delegates to `WorkflowViewStub` except when the child `ViewFactory` was also created with `bindCompose`. In that case, it just invokes that factory's Composable function directly to avoid jumping back out into legacy View land.

Add the ability to display nested renderings with bindCompose.

…pose factories. Also introduces a `ComposeViewFactoryRoot` `ViewEnvironment` key to allow "initializing" ambients and other compose context for all nested composables. Fixes #9.

Make nested bindCompose factories child compositions of outer bindCompose factories.

Requires forcing the version of the coroutine libraries that the Workflow core artifacts transitively bring in down to 1.3.0, due to a bug in version dev10 of Compose (see #13, and [this slack message](https://kotlinlang.slack.com/archives/CJLTWPH7S/p1589450805381700?thread_ts=1588232959.054500&cid=CJLTWPH7S)).

Add previews to composables in samples.

Move all common UI test dependencies into shared setup file.

…h Compose's Preview.

Introduce tooling module with support for previewing ViewBindings with Compose's Preview.

This is the third flavor of integration, it replaces `setContentWorkflow`, `WorkflowLayout`, `WorkflowRunnerViewModel`, etc., and makes it really easy to run a `Workflow` inside a pure Compose app. It's compatible with `ViewEnvironment`/`ViewRegistry`, but doesn't require it – it gives you the root rendering, and you can do whatever you want with it. It also supports running root `ComposeWorkflow`s directly, since they are self-rendering.

Introduce WorkflowContainer for running a workflow inside a Compose app.

This change reorganizes some of the wrapper logic to live closer to related code, and moves a bunch of internal-only helper code into an internal package to make the public API more browseable.

Input to legacy views hosted inside a composition seems to (partially) work now! The positions are a little off, but you can see buttons being clicked. There's a bug in our subcomposition infra that causes infinite rerenders, and prevents updates from actually showing up in legacy views, but I'll fix that in a follow- up.

Upgrade Compose to dev11.

Upgrade gradle to latest version.

Upgrade Compose to latest version.

Upgrade Gradle to latest version.

Upgrade AGP to alpha14.

Upgrade AGP.

Fix the samples not being full-size.

Upgrade compose to alpha06.

This seems to fix #79.

Upgrade Compose to alpha07.

Update indentation to match latest code style.

…d team in CODEOWNERS.

Replace individual UI Systems team members with the ui-systems-android team in CODEOWNERS.

…o the main workflow-kotlin repo.

Move everything into a compose subdirectory to prep for importing into the main workflow-kotlin repo.

…pose * compose/main: (66 commits) Move everything into a compose subdirectory to prep for importing into the main workflow-kotlin repo. Replace individual UI Systems team members with the ui-systems-android team in CODEOWNERS. Update indentation to match latest code style. Upgrade Compose to alpha07. Fix the samples not being full-size. Upgrade compose to alpha06. Upgrade AGP. Upgrade AGP to alpha14. Upgrade Gradle to latest version. Upgrade Compose to latest version. Remove redundant parentheses after @composable annotations. Remove coroutine forced dependency resolution. Upgrade Compose and AGP to latest versions. Upgrade Kotlin to 1.4.10. Upgrade Compose to alpha02. Upgrade AGP to 4.2.0-alpha10. Upgrade gradle to 6.6.1. Upgrade Compose to 1.0.0-alpha01. Upgrade to Kotlin 1.4. Upgrade Gradle to 6.6. ...

zach-klippenstein · 2021-02-04T21:40:21Z

Since there are a lot of commits here, note the last one in particular: 6a9257c. This commit excludes the compose directory from some of our build tooling.

zach-klippenstein and others added 30 commits May 11, 2020 10:57

Initial import of Compose support from main Workflow repo.

9e76b35

Add workaround for Nexus issue with sha256/512 checksums.

dea0cce

See gradle/gradle#11308.

Remove unused JMH dependencies and configuration.

c793477

Remove unused dependencies.

2e48b4d

Merge pull request #3 from square/zachklipp/workaround-nexus-bug

83f9119

Add workaround for Nexus issue with sha256/512 checksums.

Merge pull request #4 from square/zachklipp/remove-jmh

6114457

Remove unused JMH dependencies and configuration.

Merge branch 'zachklipp/cleanup-dependencies'

2ecfa22

* zachklipp/cleanup-dependencies: Remove unused dependencies.

Upgrade workflow and coroutine dependencies to latest versions.

fd09920

Merge pull request #2 from square/zachklipp/upgrade-workflow

c9fc9c5

Upgrade workflow dependencies to latest version.

Cleanup how ComposableViewFactory handles initial rendering.

4060030

Duplicate of square/workflow#1146

Merge pull request #6 from square/zachklipp/compose-nullsafe

e91c68d

Cleanup how ComposableViewFactory handles initial rendering.

Merge branch 'zachklipp/composeworkflow'

46c8d87

* zachklipp/composeworkflow: Introduce ComposeWorkflow, a self-rendering Workflow.

Merge pull request #7 from square/zachklipp/compose-nesting

d085cbf

Add the ability to display nested renderings with bindCompose.

Make nested bindCompose factories child compositions of outer bindCom…

0fed244

…pose factories. Also introduces a `ComposeViewFactoryRoot` `ViewEnvironment` key to allow "initializing" ambients and other compose context for all nested composables. Fixes #9.

Merge pull request #10 from square/zachklipp/composable-decorator

63e002f

Make nested bindCompose factories child compositions of outer bindCompose factories.

Move all common UI test dependencies into shared setup file.

15b06ca

Merge pull request #14 from square/zachklipp/previews

c506b7e

Add previews to composables in samples.

Merge pull request #11 from square/zachklipp/cleanup-test-deps

275080a

Move all common UI test dependencies into shared setup file.

Introduce tooling module with support for previewing ViewBindings wit…

d3e4f38

…h Compose's Preview.

Merge pull request #15 from square/zachklipp/compose-tooling

039f1c8

Introduce tooling module with support for previewing ViewBindings with Compose's Preview.

Merge pull request #16 from square/zachklipp/compose-root

059db5e

Introduce WorkflowContainer for running a workflow inside a Compose app.

Tidy up the package structure.

debc500

This change reorganizes some of the wrapper logic to live closer to related code, and moves a bunch of internal-only helper code into an internal package to make the public API more browseable.

Upgrade gradle to latest version.

56165a1

Merge pull request #26 from square/zachklipp/dev11

6daf2e7

Upgrade Compose to dev11.

Merge pull request #25 from square/zachklipp/upgrade-gradle

471c856

Upgrade gradle to latest version.

zach-klippenstein and others added 20 commits October 14, 2020 12:21

Merge pull request #73 from square/zachklipp/upgrade-compose

b7aa02e

Upgrade Compose to latest version.

Upgrade Gradle to latest version.

96e7654

Merge pull request #74 from square/zachklipp/upgrade-gradle

a02e6c8

Upgrade Gradle to latest version.

Upgrade AGP to alpha14.

3ead7dd

Merge pull request #75 from square/zachklipp/upgrade-agp

b449cff

Upgrade AGP to alpha14.

Upgrade AGP.

44dd2e6

Merge pull request #76 from square/zachklipp/upgrade-agp

c419bc6

Upgrade AGP.

Upgrade compose to alpha06.

caf1d4a

Fix the samples not being full-size.

ec5695e

Merge pull request #78 from square/zachklipp/fix-samples

34a70a5

Fix the samples not being full-size.

Merge pull request #77 from square/zachklipp/upgrade-compose

79441ac

Upgrade compose to alpha06.

Upgrade Compose to alpha07.

a883cff

This seems to fix #79.

Merge pull request #80 from square/zachklipp/upgrade-compose

6798cf5

Upgrade Compose to alpha07.

Update indentation to match latest code style.

d47c0ae

Merge pull request #83 from square/zachklipp/update-indentation

b478140

Update indentation to match latest code style.

Replace individual UI Systems team members with the ui-systems-androi…

c131e4e

…d team in CODEOWNERS.

Merge pull request #86 from square/zachklipp/update-codeowners

23b495d

Replace individual UI Systems team members with the ui-systems-android team in CODEOWNERS.

Move everything into a compose subdirectory to prep for importing int…

11893e4

…o the main workflow-kotlin repo.

Merge pull request #85 from square/zachklipp/prep-for-move-to-main-repo

96a12b3

Move everything into a compose subdirectory to prep for importing into the main workflow-kotlin repo.

zach-klippenstein force-pushed the zachklipp/import-compose branch from 35455c3 to 526d9b5 Compare February 4, 2021 21:41

zach-klippenstein marked this pull request as ready for review February 4, 2021 21:59

zach-klippenstein requested a review from a team February 4, 2021 21:59

zach-klippenstein added the compose label Feb 4, 2021

Exclude compose directory from some build checks where it has its own.

6a9257c

zach-klippenstein force-pushed the zachklipp/import-compose branch from 526d9b5 to 6a9257c Compare February 4, 2021 22:02

rjrjr approved these changes Feb 4, 2021

View reviewed changes

zach-klippenstein merged commit 4b37e1e into main Feb 4, 2021

zach-klippenstein deleted the zachklipp/import-compose branch February 4, 2021 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import workflow-kotlin-compose repo into the compose/ directory. #301

Import workflow-kotlin-compose repo into the compose/ directory. #301

zach-klippenstein commented Feb 4, 2021 •

edited

Loading

zach-klippenstein commented Feb 4, 2021 •

edited

Loading

Import workflow-kotlin-compose repo into the compose/ directory. #301

Import workflow-kotlin-compose repo into the compose/ directory. #301

Conversation

zach-klippenstein commented Feb 4, 2021 • edited Loading

zach-klippenstein commented Feb 4, 2021 • edited Loading

zach-klippenstein commented Feb 4, 2021 •

edited

Loading

zach-klippenstein commented Feb 4, 2021 •

edited

Loading