Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy modules #6

Closed
zach-klippenstein opened this issue Jun 13, 2020 · 2 comments · Fixed by #76
Closed

Delete legacy modules #6

zach-klippenstein opened this issue Jun 13, 2020 · 2 comments · Fixed by #76
Assignees
Milestone

Comments

@zach-klippenstein
Copy link
Collaborator

We're not going to be able to delete this anytime soon, and that should definitely not block 1.0. We could pull them out into a separate repo, but that would just make more work for us. We could leave them here and stop releasing new artifacts for them, but we might run into issues as they fall behind on dependencies like coroutines and kotlin. We could just keep them going publishing 0.x releases, but it's already too late for that, since we pushed the 1.0.0-alpha.1 release. We could keep them in alpha, even after the other artifacts graduate to beta/release, but we'll need to do some surgery on our build scripts.

@rjrjr WDYT?

Originally posted by @zach-klippenstein in square/workflow#548 (comment)

@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jun 13, 2020
@zach-klippenstein
Copy link
Collaborator Author

I think it's probably cleanest to just delete these from github and copy them into our internal codebase until we can delete for good.

@rjrjr
Copy link
Contributor

rjrjr commented Jun 28, 2020

I completely agree. We've done that a couple of times already and it's no big deal.

@zach-klippenstein zach-klippenstein changed the title Figure out whether to include legacy library in 1.0 release. Delete legacy modules Jun 28, 2020
zach-klippenstein added a commit that referenced this issue Jun 28, 2020
@zach-klippenstein zach-klippenstein self-assigned this Jun 28, 2020
zach-klippenstein added a commit that referenced this issue Feb 4, 2021
Cleanup how ComposableViewFactory handles initial rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants