Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flipperBlurFocus prop #33

Merged
merged 13 commits into from
Nov 21, 2019
Merged

Added flipperBlurFocus prop #33

merged 13 commits into from
Nov 21, 2019

Conversation

tdurnford
Copy link
Contributor

@tdurnford tdurnford commented Nov 13, 2019

Per microsoft/BotFramework-WebChat#1673

This PR adds the flipperBlurFocus prop to BasicFilm and the blurFocus prop to Flipper components. When flipperBlurFocus is false, which is the default value and maintains the current behavior, the flipper will keep focus on click; however, when it's true, the flipper will blur on click. Regardless of the truthiness of flipperBlurFocus, the flipper will keep focus when the user is interacting with react-film through the keyboard.

<BasicFilm height={ 316 } flipperBlurFocus={true} key={ `${ key }-a` }>
  <img alt="Cat 01" src="image/01.jpg" />
  <img alt="Cat 02" src="image/02.jpg" />
  <img alt="Cat 03" src="image/03.jpg" />
  ....
</BasicFilm>

CHANGELOG.md Outdated Show resolved Hide resolved
@tdurnford tdurnford changed the title Added flipperKeepFocus prop Added flipperBlurFocus prop Nov 13, 2019
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/component/src/BasicFilm.js Outdated Show resolved Hide resolved
packages/component/src/Flipper.js Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@tdurnford tdurnford requested a review from spyip November 15, 2019 22:55
@compulim compulim merged commit 81d7a34 into spyip:master Nov 21, 2019
@tdurnford tdurnford deleted the 1673 branch November 21, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants