Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested actions navigation arrows should indicate focus visually #1673

Closed
ljubomirsinadinovski opened this issue Jan 31, 2019 · 11 comments · Fixed by #2801
Closed

Suggested actions navigation arrows should indicate focus visually #1673

ljubomirsinadinovski opened this issue Jan 31, 2019 · 11 comments · Fixed by #2801
Assignees
Labels
blocked currently prevented from making progress bug Indicates an unexpected problem or an unintended behavior. front-burner needs-design-input UX/UI design item p1 Painful if we don't fix, won't block releasing
Milestone

Comments

@ljubomirsinadinovski
Copy link

ljubomirsinadinovski commented Jan 31, 2019

After clicking on the horizontal navigation arrow in the quick answer area, if you don't click anything else and move the cursor away we get this behavior:

  1. The CLICKED arrow doesn't disappear (still visible)
  2. The other arrow disappears (becomes invisible)

For better understanding I am including this screenshot:
screenshot at jan 31 10-17-19

And forgot to add that the change in styleSet doesn't affect these arrows

ANOTHER BUG:
Another bug (that is included in version: "botframework-webchat": "^4.2.1-master.0dffd85",) is that the actions have quotes around them (you can notice them on the picture above) , while I am receiving them without quotes from directLine (checked in the json that I received).

BTW: I know that 4.2.1 is not official yet, but 4.2.0 is too broken for my implementation, sry.

@corinagum
Copy link
Contributor

corinagum commented Jan 31, 2019

Confirmed repro of this bug on MockBot:
image
Related to your second comment, we already have #1586 open for tracking this issue.

Your last bug has been resolved and can be utilized in the latest bits. #1602 Otherwise the fix will be released with 4.3

Note to fixer:

This bug should be fixed at the same time as #1586

@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. p1 Painful if we don't fix, won't block releasing Triage-E labels Jan 31, 2019
@corinagum corinagum changed the title Quick Answer Navigation Arrow Bug Suggested actions navigation arrows do not disappear as expected Jan 31, 2019
@compulim compulim self-assigned this Jan 31, 2019
@compulim
Copy link
Contributor

If the button is focused, it won't slide away, for accessibility reason. That's why the button is still there.

Maybe we use a non-keyboard gesture to click on it, we should blur the focus. Need to investigate a good and reliable solution to differentiate between keyboard focus and mouse click focus.

@compulim compulim removed their assignment Feb 15, 2019
@compulim compulim added the community-help-wanted This is a good issue for a contributor to take on and submit a solution label Feb 15, 2019
@corinagum corinagum removed the Pending label Feb 20, 2019
@corinagum corinagum self-assigned this Apr 1, 2019
@cwhitten cwhitten added 4.5 and removed 4.4 labels Apr 2, 2019
@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed 4.5 labels Apr 2, 2019
@corinagum
Copy link
Contributor

Provide better focus indication on this element

@corinagum corinagum changed the title Suggested actions navigation arrows do not disappear as expected Suggested actions navigation arrows should indicate focus visually May 15, 2019
@corinagum corinagum removed their assignment May 15, 2019
@tdurnford tdurnford self-assigned this May 16, 2019
@DesignPolice
Copy link

@compulim @corinagum @tdurnford

Hello, @tdurnford tagged me on this, I'm not clear from this thread if we have figured out a fix for this or not? @compulim last comment seems to imply we need to research a better solution for Accessibility or do I just need some heavier focus lines to make it more obvious?? @corinagum looks like you "tapped" out on this one?

@corinagum
Copy link
Contributor

Yeah, @tdurnford is taking over this one. Right now there is no focus indication on the flippers, so he tagged you I guess to get your input. We discussed the possibility of adding distinction between a keyboard and mouse event, but @cwhitten is satisfied with us having focus indication to improve the UX. This will sufficiently indicate why the button doesn't immediately disappear.

@DesignPolice
Copy link

Thanks @corinagum - @compulim do we have any Focus traits in WebChat currently? My MockBot isn't working to verify.

@corinagum
Copy link
Contributor

You can look at our sample bots to hunt around for focus indicators. Click the 'Try out MockBot' link on the sample.

@corinagum
Copy link
Contributor

the design specs above do not factor in the shape of the focus indicator, which is a circle.

@corinagum corinagum added 4.6 and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Jul 10, 2019
@Kaiqb Kaiqb added the Customer label Jul 23, 2019
@sgellock sgellock removed the Customer label Aug 8, 2019
@cwhitten cwhitten removed the 4.6 label Sep 17, 2019
@tdurnford
Copy link
Contributor

Bumping the react-film dependency to the next version and adding the flipperBlurFocusOnClick to the suggested actions and attachment carousel film strip should resolve this issue.

@corinagum corinagum added R7 and removed community-help-wanted This is a good issue for a contributor to take on and submit a solution needs-repro Waiting for repro or investigation labels Nov 21, 2019
@corinagum
Copy link
Contributor

react-film has been updated, now we need release and bump.

@corinagum corinagum added the blocked currently prevented from making progress label Nov 21, 2019
@cwhitten cwhitten added R8 and removed R7 labels Dec 4, 2019
@corinagum corinagum added this to the R8 milestone Jan 15, 2020
@compulim compulim mentioned this issue Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked currently prevented from making progress bug Indicates an unexpected problem or an unintended behavior. front-burner needs-design-input UX/UI design item p1 Painful if we don't fix, won't block releasing
Projects
None yet
8 participants