Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate DatatypeConverter Usage #590

Closed
jzheaux opened this issue Nov 23, 2021 · 0 comments
Closed

Isolate DatatypeConverter Usage #590

jzheaux opened this issue Nov 23, 2021 · 0 comments
Assignees
@jzheaux
Labels
in: core type: enhancement
Milestone
2.3.5

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 23, 2021

In JDK 11, javax.xml.bind is dropped and so Spring LDAP needs to find an alternative to DatatypeConverter in order to be runnable in JDK 11+.

Because Spring LDAP 2.3.x compiles to JDK 6, it's not as simple as changing to use java.util.Base64. Instead, the code should:

  • check if the java.util.Base64 class is present. If so, use it
  • otherwise, continue using DatatypeConverter

Since this is passive, it can be introduced in a point release.
@jzheaux jzheaux self-assigned this Nov 23, 2021
@jzheaux jzheaux added this to the 2.3.5 milestone Nov 23, 2021
fmbenhassine added a commit to spring-projects/spring-batch that referenced this issue Nov 25, 2021
@fmbenhassine
Reactivate LdifReader tests
e8e3f5d 
These tests were ignored in 5dc17b1
due to a runtime issue with spring-ldap.
This issue has been fixed in
spring-projects/spring-ldap#590.
@basil basil mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: core type: enhancement
Projects
None yet
Milestone
2.3.5
Development

No branches or pull requests
1 participant
@jzheaux