Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68462] Prepare LDAP for removal of JAXB and Java 11 requirement #149

Merged
merged 1 commit into from
May 10, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 9, 2022

See JENKINS-68462. The current version of this plugin bundles an old version of spring-ldap-core, which requires JAXB. When we start requiring Java 11, JAXB will not be available except as a plugin-to-plugin dependency (which this plugin does not have). In spring-projects/spring-ldap#590 spring-ldap-core 2.3.5 and later stopped requiring JAXB. This PR updates the core baseline to 2.332.x, which pulls in a newer version of spring-security-bom, which pulls in spring-ldap-core 2.3.5 (2.303.x pulls in 2.3.4, sadly). Thus with this update we start shipping spring-ldap-core 2.3.5 which no longer depends on JAXB, and thus we are assured of a smooth upgrade for users when we start requiring Java 11.

Testing done

$ mvn clean verify
[…]
[INFO] Assembling webapp ldap in ldap-plugin/target/ldap
[INFO] Bundling direct dependency time4j-base-5.8.jar
[INFO] Bundling direct dependency time4j-tzdata-5.0-2021e.jar
[WARNING] Bundling transitive dependency spring-ldap-core-2.3.5.RELEASE.jar (via spring-security-ldap)
[INFO] Bundling direct dependency spring-security-ldap-5.6.1.jar
[WARNING] Bundling transitive dependency spring-tx-5.3.14.jar (via spring-security-ldap)
[INFO] Generating hpi ldap-plugin/target/ldap.hpi
[INFO] Building jar: ldap-plugin/target/ldap.hpi
[…]
$

@basil
Copy link
Member Author

basil commented May 10, 2022

CC @olamy

@olamy olamy merged commit e94b4a3 into jenkinsci:master May 10, 2022
@basil basil deleted the JENKINS-68462 branch May 10, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants