KafkaItemWriter.write should not return until items are confirmed to have been written #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til items are confirmed to have been written
jbotuck
force-pushed
the
feature/issue-3773
branch
from
28518f2
to
3acbaaa
Compare
fmbenhassine
added a commit
that referenced
this pull request
Mar 9, 2021
* Update year in licence headers * Update Javadoc * Add `this` keyword where appropriate
|
LGTM. Rebased and merged as c886a60. Refined in 572a302. I also added a timeout to prevent the job from running indefinitely if |
fmbenhassine
changed the title
fmbenhassine
added a commit
that referenced
this pull request
Mar 9, 2021
* Update year in licence headers * Update Javadoc * Add `this` keyword where appropriate
fmbenhassine
added a commit
that referenced
this pull request
Mar 9, 2021
* Update year in licence headers * Update Javadoc * Add `this` keyword where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #3773.