Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KafkaItemWriter should wait for results of kafkaTemplate.sendDefault call #3773

Closed
jbotuck opened this issue Sep 11, 2020 · 1 comment
Closed

KafkaItemWriter should wait for results of kafkaTemplate.sendDefault call #3773

jbotuck opened this issue Sep 11, 2020 · 1 comment
Labels
for: backport-to-4.2.x Issues that will be back-ported to the 4.2.x line in: infrastructure related-to: item-readers-writers type: bug
Milestone
4.3.2

Comments

@jbotuck
Copy link
Contributor

jbotuck commented Sep 11, 2020 •
edited
Loading

I noticed the kafkaItemWriter calls sendDefault (an asynchronous call) without checking the future returned by the call to confirm the data was actually sent. This seems bad to me. I would think it should call flush on the template after the batch is written and then check all the futures to confirm nothing went wrong.
@jbotuck jbotuck added status: waiting-for-triage Issues that we did not analyse yet type: feature labels Sep 11, 2020
jbotuck added a commit to jbotuck/spring-batch that referenced this issue Jan 5, 2021
@jbotuck
issue spring-projects#3773 KafkaItemWriter.write should not return un…
28518f2 
…til items are confirmed to have been written
@fmbenhassine fmbenhassine added has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure type: bug and removed status: waiting-for-triage Issues that we did not analyse yet type: feature labels Jan 15, 2021
@fmbenhassine fmbenhassine added this to the 5.0.0-M1 milestone Jan 15, 2021
@fmbenhassine fmbenhassine linked a pull request Jan 15, 2021 that will close this issue
KafkaItemWriter.write should not return until items are confirmed to have been written #3827
Closed
@fmbenhassine fmbenhassine modified the milestones: 5.0.0-M1, 4.3.2 Jan 21, 2021
@fmbenhassine fmbenhassine added for: backport-to-4.2.x Issues that will be back-ported to the 4.2.x line related-to: item-readers-writers and removed has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" labels Jan 21, 2021
jbotuck added a commit to jbotuck/spring-batch that referenced this issue Feb 2, 2021
@jbotuck
issue spring-projects#3773 KafkaItemWriter.write should not return un…
3acbaaa 
…til items are confirmed to have been written
fmbenhassine pushed a commit that referenced this issue Mar 9, 2021
@jbotuck @fmbenhassine
KafkaItemWriter.write should not return until items are confirmed to …
c886a60 
…have been written

Issue #3773
fmbenhassine added a commit that referenced this issue Mar 9, 2021
@fmbenhassine
Add timeout when flushing items to Kafka in KafkaItemWriter
a154968 
Issue #3773
@fmbenhassine fmbenhassine mentioned this issue Mar 9, 2021
Closed
@fmbenhassine
Copy link
Contributor

Fixed in #3827 .

fmbenhassine pushed a commit that referenced this issue Mar 9, 2021
@jbotuck @fmbenhassine
KafkaItemWriter.write should not return until items are confirmed to …
7b6b15d 
…have been written

Issue #3773
fmbenhassine added a commit that referenced this issue Mar 9, 2021
@fmbenhassine
Add timeout when flushing items to Kafka in KafkaItemWriter
e176058 
Issue #3773
fmbenhassine pushed a commit that referenced this issue Mar 9, 2021
@jbotuck @fmbenhassine
KafkaItemWriter.write should not return until items are confirmed to …
96606d9 
…have been written

Issue #3773
fmbenhassine added a commit that referenced this issue Mar 9, 2021
@fmbenhassine
Add timeout when flushing items to Kafka in KafkaItemWriter
96beb18 
Issue #3773
@fmbenhassine fmbenhassine mentioned this issue Mar 9, 2021
Closed
@fmbenhassine fmbenhassine mentioned this issue Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: backport-to-4.2.x Issues that will be back-ported to the 4.2.x line in: infrastructure related-to: item-readers-writers type: bug
Projects
None yet
Milestone
4.3.2
2 participants
@fmbenhassine @jbotuck