Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1295 reactive #1320

Merged
merged 54 commits into from
Apr 24, 2023
Merged

Fix 1295 reactive #1320

merged 54 commits into from
Apr 24, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Apr 23, 2023

No description provided.

wind57 and others added 30 commits December 4, 2021 07:59
@wind57 wind57 marked this pull request as ready for review April 24, 2023 07:36
@wind57
Copy link
Contributor Author

wind57 commented Apr 24, 2023

the changes in this PR are already done in k8s client, so this simply replicates them.

/**
* Post an event so that health indicator is initialized.
*/
@Bean
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, this is the only "real" change here, everything else are just tests to make sure that we work exactly the same as the k8s-client health wise in the discovery implementation.

@wind57
Copy link
Contributor Author

wind57 commented Apr 24, 2023

@ryanjbaxter one more minor bug fix. thank you

@ryanjbaxter ryanjbaxter merged commit ad3196b into spring-cloud:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fabric8 and k8s differ in their discovery reactive health implementations
3 participants