Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabric8 and k8s differ in their discovery reactive health implementations #1295

Closed
wind57 opened this issue Apr 8, 2023 · 0 comments · Fixed by #1320
Closed

fabric8 and k8s differ in their discovery reactive health implementations #1295

wind57 opened this issue Apr 8, 2023 · 0 comments · Fixed by #1320
Labels
Milestone

Comments

@wind57
Copy link
Contributor

wind57 commented Apr 8, 2023

In the k8s discovery we do :

	@Bean
	@ConditionalOnClass(name = "org.springframework.boot.actuate.health.ReactiveHealthIndicator")
	@ConditionalOnDiscoveryHealthIndicatorEnabled
	public ReactiveDiscoveryClientHealthIndicator kubernetesReactiveDiscoveryClientHealthIndicator(
			KubernetesInformerReactiveDiscoveryClient client, DiscoveryClientHealthIndicatorProperties properties,
			KubernetesClientPodUtils podUtils) {
		ReactiveDiscoveryClientHealthIndicator healthIndicator = new ReactiveDiscoveryClientHealthIndicator(client,
				properties);
		InstanceRegisteredEvent<?> event = new InstanceRegisteredEvent<>(podUtils.currentPod(), null);
		healthIndicator.onApplicationEvent(event);
		return healthIndicator;
	}

that is: we publish InstanceRegisteredEvent. In the fabric8 one:

	@Bean
	@ConditionalOnClass(name = "org.springframework.boot.actuate.health.ReactiveHealthIndicator")
	@ConditionalOnDiscoveryHealthIndicatorEnabled
	public ReactiveDiscoveryClientHealthIndicator kubernetesReactiveDiscoveryClientHealthIndicator(
			KubernetesReactiveDiscoveryClient client, DiscoveryClientHealthIndicatorProperties properties) {
		return new ReactiveDiscoveryClientHealthIndicator(client, properties);
	}

that is: we do not publish the InstanceRegisteredEvent.

imo, we should fix fabric8 one.

@wind57 wind57 changed the title fabric8 and k8s differ in their reactive health implementation fabric8 and k8s differ in their discovery reactive health implementations Apr 8, 2023
@ryanjbaxter ryanjbaxter linked a pull request Apr 24, 2023 that will close this issue
@ryanjbaxter ryanjbaxter added this to the 3.0.3 milestone Apr 24, 2023
@github-project-automation github-project-automation bot moved this to Done in 2022.0.3 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants