-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable external metastores #483
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
284f929
External catalog skeleton impl
gruuya c48d8d7
Refactor catalog.rs into a module
gruuya 1ff1b7d
Add basic read-only external catalog implementation
gruuya a565470
Add an end-to-end test for the external store
gruuya 3f365c1
Expose reflection metadata
mildbyte dddd0a3
Simplify the schema store protobuf structure
gruuya a9671ef
Lazy connect to the external metastore
gruuya 16a0daf
Remove 1s sleep from the external metastore test
gruuya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[package] | ||
name = "clade" | ||
version = "0.1.0" | ||
edition = "2021" | ||
|
||
[dependencies] | ||
prost = "0.12" | ||
tonic = "0.10" | ||
|
||
[build-dependencies] | ||
tonic-build = "0.10" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
use std::env; | ||
use std::path::PathBuf; | ||
|
||
fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
let out_dir = PathBuf::from(env::var("OUT_DIR").unwrap()); | ||
tonic_build::configure() | ||
.file_descriptor_set_path(out_dir.join("clade_descriptor.bin")) | ||
.build_server(true) | ||
.build_client(true) | ||
.compile(&["proto/schema.proto"], &["proto"])?; | ||
|
||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
syntax = "proto3"; | ||
|
||
package clade.schema; | ||
|
||
message SchemaObject { | ||
string name = 1; | ||
repeated TableObject tables = 2; | ||
} | ||
|
||
message TableObject { | ||
string name = 1; | ||
string location = 2; | ||
} | ||
|
||
message ListSchemaRequest { | ||
string catalog_name = 1; | ||
} | ||
|
||
message ListSchemaResponse { | ||
repeated SchemaObject schemas = 1; | ||
} | ||
|
||
service SchemaStoreService { | ||
// List the available schemas | ||
rpc ListSchemas(ListSchemaRequest) returns (ListSchemaResponse); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pub mod schema { | ||
tonic::include_proto!("clade.schema"); | ||
pub const FILE_DESCRIPTOR_SET: &[u8] = | ||
tonic::include_file_descriptor_set!("clade_descriptor"); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well keep calling it
clade
, though we might need to get more people involved in naming it if we ever want to spin it out into a separate open source project. (alternative name: simplyseafowl-metastore
)