-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable external metastores #483
Conversation
42ab9bd
to
6ce1526
Compare
Also rename floc crate to clade.
6ce1526
to
a565470
Compare
clade/proto/schema.proto
Outdated
|
||
service SchemaStoreService { | ||
// List the available schemas | ||
rpc List(catalog.CatalogReference) returns (ListSchemaResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a best practice here is naming these types as per the method (https://protobuf.dev/programming-guides/style/#message-field-names), e.g. GetCatalog(GetCatalogRequest) returns (GetCatalogResponse)
pub const DEFAULT_SCHEMA: &str = "public"; | ||
pub const STAGING_SCHEMA: &str = "staging"; | ||
|
||
#[derive(Debug, thiserror::Error)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual error handling library, nice
tests/clade/query.rs
Outdated
let (context, clade) = start_clade_server().await; | ||
tokio::task::spawn(clade); | ||
|
||
tokio::time::sleep(tokio::time::Duration::from_secs(1)).await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmmm is there no better way to wait until it's up and running? this can randomly fail if something is having a slow day
clade/Cargo.toml
Outdated
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html |
@@ -0,0 +1,13 @@ | |||
[package] | |||
name = "clade" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well keep calling it clade
, though we might need to get more people involved in naming it if we ever want to spin it out into a separate open source project. (alternative name: simply seafowl-metastore
)
Added the metadata required to expose a reflection service (useful for GUI gRPC clients): #484 |
External metastore support via a gRPC interface, Closes #485.