Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): add Retrofit2SyncCall.execute to ClouddriverService in CredentialsController (backport #1881) #1882

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix(web): add Retrofit2SyncCall.execute to ClouddriverService in CredentialsController (backport #1881) #1882

merged 1 commit into from
Feb 28, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 28, 2025

CredentialsController has ClouddriverService calls which needed Retrofit2SyncCall.execute.

Added a test to demonstrate the issue.

This is an automatic backport of pull request #1881 done by Mergify.

@kirangodishala @mergify
fix(web): add Retrofit2SyncCall.execute to ClouddriverService in Cred…
0f50c57 
…entialsController (#1881)

* test(web): add a test to demonstrate the retrofit error that occurs when /credentials/type/{accountType} is invoked

* fix(web): add Retrofit2SyncCall.execute to ClouddriverService in CredentialsController

(cherry picked from commit 5b500d3)
@mergify mergify bot mentioned this pull request Feb 28, 2025
Merged
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Feb 28, 2025
@mergify mergify bot added the auto merged label Feb 28, 2025
@mergify mergify bot merged commit 2db175e into release-1.37.x Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.37
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbyron-sf @spinnakerbot @kirangodishala