fix(web): add Retrofit2SyncCall.execute to ClouddriverService in CredentialsController #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirangodishala
force-pushed
the
fix-retrofit2-credentialscontroller
branch
from
df9c38a to
33e9fc9
Compare
…hen /credentials/type/{accountType} is invoked
…entialsController
kirangodishala
force-pushed
the
fix-retrofit2-credentialscontroller
branch
from
33e9fc9 to
2d2c9ee
Compare
dbyron-sf
approved these changes
Feb 28, 2025
|
@Mergifyio backport release-1.37.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Feb 28, 2025
…entialsController (#1881) (#1882) * test(web): add a test to demonstrate the retrofit error that occurs when /credentials/type/{accountType} is invoked * fix(web): add Retrofit2SyncCall.execute to ClouddriverService in CredentialsController (cherry picked from commit 5b500d3) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CredentialsController has ClouddriverService calls which needed Retrofit2SyncCall.execute.
Added a test to demonstrate the issue.