Skip to content

Commit

Permalink
chore(glob): fix compile [#267]
Browse files Browse the repository at this point in the history
  • Loading branch information
j-mendez committed Feb 13, 2025
1 parent bfffec3 commit 85a911f
Show file tree
Hide file tree
Showing 11 changed files with 370 additions and 267 deletions.
12 changes: 6 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/url_glob.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//! `cargo run --example url_glob --features glob`
//! cargo run --example url_glob --features glob
extern crate spider;

use spider::tokio;
Expand Down
2 changes: 1 addition & 1 deletion spider/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "spider"
version = "2.27.61"
version = "2.27.62"
authors = [
"j-mendez <jeff@spider.cloud>"
]
Expand Down
4 changes: 2 additions & 2 deletions spider/src/configuration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ impl Configuration {
delay: 0,
depth: 25,
redirect_limit: Box::new(7),
request_timeout: Some(Box::new(Duration::from_secs(15))),
request_timeout: Some(Box::new(Duration::from_secs(60))),
only_html: true,
..Default::default()
}
Expand All @@ -378,7 +378,7 @@ impl Configuration {
delay: 0,
depth: 25,
redirect_limit: Box::new(7),
request_timeout: Some(Box::new(Duration::from_secs(15))),
request_timeout: Some(Box::new(Duration::from_secs(60))),
chrome_intercept: RequestInterceptConfiguration::new(cfg!(
feature = "chrome_intercept"
)),
Expand Down
3 changes: 2 additions & 1 deletion spider/src/features/chrome.rs
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,8 @@ pub(crate) async fn attempt_navigation(
viewport: &Option<crate::features::chrome_common::Viewport>,
) -> Result<Page, CdpError> {
let mut cdp_params = CreateTargetParams::new(url);
cdp_params.background = Some(browser_context_id.is_some());

cdp_params.background = Some(browser_context_id.is_some()); // not supported headless-shell
cdp_params.browser_context_id.clone_from(browser_context_id);
cdp_params.url = url.into();
cdp_params.for_tab = Some(false);
Expand Down
Loading

0 comments on commit 85a911f

Please sign in to comment.