chore(chrome): add optional cache disable

spider-rs · Feb 13, 2025 · bfffec3 · bfffec3
1 parent d259ed5
commit bfffec3
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 17 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/spider/Cargo.toml b/spider/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "spider"
-version = "2.27.60"
+version = "2.27.61"
 authors = [
     "j-mendez <jeff@spider.cloud>"
 ]

diff --git a/spider_chrome/Cargo.toml b/spider_chrome/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "spider_chrome"
-version = "2.27.60"
+version = "2.27.61"
 rust-version = "1.70"
 authors = [
     "j-mendez <jeff@spider.cloud>"

diff --git a/spider_chrome/src/handler/network.rs b/spider_chrome/src/handler/network.rs
@@ -134,6 +134,7 @@ pub struct NetworkManager {
     user_cache_disabled: bool,
     attempted_authentications: HashSet<RequestId>,
     credentials: Option<Credentials>,
+    // unused atm for remote connections, needs to be used for self launches.
     user_request_interception_enabled: bool,
     protocol_request_interception_enabled: bool,
     offline: bool,
@@ -257,6 +258,7 @@ impl NetworkManager {
         if enabled == self.protocol_request_interception_enabled {
             return;
         }
+
         self.update_protocol_cache_disabled();
 
         if enabled {

diff --git a/spider_chrome/src/handler/target.rs b/spider_chrome/src/handler/target.rs
@@ -132,17 +132,20 @@ impl Target {
         let request_timeout = config.request_timeout;
         let mut network_manager = NetworkManager::new(config.ignore_https_errors, request_timeout);
 
-        network_manager.set_cache_enabled(config.cache_enabled);
+        if !config.cache_enabled {
+            network_manager.set_cache_enabled(false);
+        }
+
+        if !config.service_worker_enabled {
+            network_manager.set_service_worker_enabled(true);
+        }
+
         network_manager.set_request_interception(config.request_intercept);
 
         if let Some(ref headers) = config.extra_headers {
             network_manager.set_extra_headers(headers.clone());
         }
 
-        if !config.service_worker_enabled {
-            network_manager.set_service_worker_enabled(config.service_worker_enabled);
-        }
-
         network_manager.ignore_visuals = config.ignore_visuals;
         network_manager.block_javascript = config.ignore_javascript;
         network_manager.block_analytics = config.ignore_analytics;

diff --git a/spider_cli/Cargo.toml b/spider_cli/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "spider_cli"
-version = "2.27.60"
+version = "2.27.61"
 authors = [
     "j-mendez <jeff@spider.cloud>"
 ]

diff --git a/spider_transformations/Cargo.toml b/spider_transformations/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "spider_transformations"
-version = "2.27.60"
+version = "2.27.61"
 authors = [
     "j-mendez <jeff@spider.cloud>"
 ]

diff --git a/spider_utils/Cargo.toml b/spider_utils/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "spider_utils"
-version = "2.27.60"
+version = "2.27.61"
 authors = [
     "j-mendez <jeff@spider.cloud>"
 ]

diff --git a/spider_worker/Cargo.toml b/spider_worker/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "spider_worker"
-version = "2.27.60"
+version = "2.27.61"
 authors = [
     "j-mendez <jeff@spider.cloud>"
 ]