Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance (2024-03-02) #899

Merged
merged 26 commits into from
Mar 3, 2024
Merged

Maintenance (2024-03-02) #899

merged 26 commits into from
Mar 3, 2024

Commits on Mar 2, 2024

  1. tests: remove legacy python file coding 

    Removing legacy Python file encoding from sample Python files. They are
not needed for the specific testing or examples, and best to avoid their
promotion in our example. Removing also prevents ruff warnings on their
detection.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    4e7a6e9 View commit details
    Browse the repository at this point in the history

  2. refactor define processing from a mainline 

    Tweaking the processing of accepting defines from a command line
argument by:

- Moving the value error process outside the defines loop for
   performance (PERF203).
- Adjusting the define loop to be a bit more explicit between a define
   entry and a define's value.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    075decb View commit details
    Browse the repository at this point in the history

  3. tests: update expected line-count with test asset change 

    Since a test asset's line length has been changed [1], the unit test
using this asset also needs to be updated.

[1]: 4e7a6e9

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    f2ea993 View commit details
    Browse the repository at this point in the history

  4. builder: noqa on private member access of sphinx's writer doc cache 

    Adding a noqa warning on using a Sphinx private member variable required
for a workaround (at this time) for this extension's doctree
manipulations.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    82bf0a6 View commit details
    Browse the repository at this point in the history

  5. rework for-loops to ignore unused values 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    76a48d3 View commit details
    Browse the repository at this point in the history

  6. implicitly concatenated string 

    Update various messages defined over multiple lines to be implicitly
concatenated string (ISC002).

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    018e635 View commit details
    Browse the repository at this point in the history

  7. use suppressible exception over try-except-pass 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    899eaab View commit details
    Browse the repository at this point in the history

  8. remove various variable/function shadowing 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    dd14921 View commit details
    Browse the repository at this point in the history

  9. remove superfluous else return 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c3e1074 View commit details
    Browse the repository at this point in the history

  10. add exception chaining on various exceptions 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    5b1502f View commit details
    Browse the repository at this point in the history

  11. add trailing commas (COM812) 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    fa3c849 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary parenthesis 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    23951db View commit details
    Browse the repository at this point in the history

  13. simplify verbose lines 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    96c98c5 View commit details
    Browse the repository at this point in the history

  14. explicit stty paths for getpass override 

    Update stty calls to use an explicit path, to prevent any unexpected
PATH overrides.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    82623a1 View commit details
    Browse the repository at this point in the history

  15. suppress linter warning on aliased locale translation function 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    13f9a84 View commit details
    Browse the repository at this point in the history

  16. suppress linter subprocess warnings on non-input calls 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c334d8a View commit details
    Browse the repository at this point in the history

  17. suppress linter security warning on random call 

    The existing implementation to randomizing the delay for request tries
is not a security concern.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    0de7c90 View commit details
    Browse the repository at this point in the history

  18. tests: explicit capture of builder init call 

    There is no difference between capturing the init call explicitly or
via the `getattr` style; updating to the simpler variant.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    de012bd View commit details
    Browse the repository at this point in the history

  19. simplify various attribute set-exists checks 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    4ec94db View commit details
    Browse the repository at this point in the history

  20. remove superfluous else return 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    0ff0503 View commit details
    Browse the repository at this point in the history

  21. suppress xml recursion warnings for trusted svg/sites 

    The use of XML parsers targets user-provided SVGs and only targets
users Confluence instances (in debug cases). It is expected that these
are trusted sources for users, so adding noqa's for any linter warnings.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    f7ccc22 View commit details
    Browse the repository at this point in the history

  22. config: provide defaults for legacy search-mode handling 

    When searching for legacy configuration options using `getattr`, ensure
defaults are provided to avoid undesired `AttributeError` exceptions.
This logic was intended to not throw exceptions, but never properly
added the default cases to avoid it.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    1d29624 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. config: move publish-debug opts into except block 

    Publish debug options are only relevant to the exception raised in the
configuration's exception block; moving.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    e922c1b View commit details
    Browse the repository at this point in the history

  2. remove obsolete linter hints 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    e3bf7b9 View commit details
    Browse the repository at this point in the history

  3. various linter tweaks 

    Tweaking a series of loops, ifs and exception to cleaning up linter
warnings when running ruff.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    85e01ca View commit details
    Browse the repository at this point in the history

  4. tox: bump ruff version 

    Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4666d8c View commit details
    Browse the repository at this point in the history