Maintenance (2024-03-02) #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing legacy Python file encoding from sample Python files. They are not needed for the specific testing or examples, and best to avoid their promotion in our example. Removing also prevents ruff warnings on their detection. Signed-off-by: James Knight <james.d.knight@live.com>
Tweaking the processing of accepting defines from a command line argument by: - Moving the value error process outside the defines loop for performance (PERF203). - Adjusting the define loop to be a bit more explicit between a define entry and a define's value. Signed-off-by: James Knight <james.d.knight@live.com>
Since a test asset's line length has been changed [1], the unit test using this asset also needs to be updated. [1]: 4e7a6e9 Signed-off-by: James Knight <james.d.knight@live.com>
Adding a noqa warning on using a Sphinx private member variable required for a workaround (at this time) for this extension's doctree manipulations. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Update various messages defined over multiple lines to be implicitly concatenated string (ISC002). Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Update stty calls to use an explicit path, to prevent any unexpected PATH overrides. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
The existing implementation to randomizing the delay for request tries is not a security concern. Signed-off-by: James Knight <james.d.knight@live.com>
There is no difference between capturing the init call explicitly or via the `getattr` style; updating to the simpler variant. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
The use of XML parsers targets user-provided SVGs and only targets users Confluence instances (in debug cases). It is expected that these are trusted sources for users, so adding noqa's for any linter warnings. Signed-off-by: James Knight <james.d.knight@live.com>
When searching for legacy configuration options using `getattr`, ensure defaults are provided to avoid undesired `AttributeError` exceptions. This logic was intended to not throw exceptions, but never properly added the default cases to avoid it. Signed-off-by: James Knight <james.d.knight@live.com>
Publish debug options are only relevant to the exception raised in the configuration's exception block; moving. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Tweaking a series of loops, ifs and exception to cleaning up linter warnings when running ruff. Signed-off-by: James Knight <james.d.knight@live.com>
Signed-off-by: James Knight <james.d.knight@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs a series of tweaks to the implementation to address linter issues when running ruff.